Skip to content

Commit b966252

Browse files
authored
Fix comments in encode_append (#2)
* Fix comments in encode_append
1 parent 4be4c9f commit b966252

3 files changed

Lines changed: 10 additions & 10 deletions

File tree

CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ endif()
4141

4242
include(GNUInstallDirs)
4343

44-
install(TARGETS scale buffer EXPORT scaleConfig
44+
install(TARGETS scale buffer scale_encode_append EXPORT scaleConfig
4545
LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
4646
ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}
4747
RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}

include/scale/encode_append.hpp

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -27,20 +27,20 @@ namespace scale {
2727
}
2828

2929
/**
30-
* Adds to scale encoded vector of EncodeOpaqueValue another
31-
* EncodeOpaqueValue. If current vector is empty, then it is replaced by new
30+
* Adds an EncodeOpaqueValue to a scale encoded vector of EncodeOpaqueValue's.
31+
* If the current vector is empty, then it is replaced by a new
3232
* EncodeOpaqueValue
33-
* In other words what actually happens could be implemented like that:
33+
* In other words, what actually happens could be implemented like that:
3434
* @code{.cpp}
3535
* auto vec = scale::decode<vector<EncodeOpaqueValue>>(self_encoded);
3636
* vec.push_back(scale::encode(EncodeOpaqueValue(input));
3737
* self_encoded = scale::encode(vec);
3838
* @endcode
39-
* but actual implementation a bit more optimal
40-
* @param self_encoded Current encoded vector of EncodeOpaqueValue
41-
* @param input is a vector, that is encoded as EncodeOpaqueValue and added to
42-
* @param self_encoded
43-
* @return success input was appended to self_encoded, failure otherwise
39+
* but the actual implementation is a bit more optimal
40+
* @param self_encoded - An encoded vector of EncodeOpaqueValue
41+
* @param input - A vector encoded as an EncodeOpaqueValue and added to
42+
* \param self_encoded
43+
* @return success if input was appended to self_encoded, failure otherwise
4444
*/
4545
outcome::result<void> append_or_new_vec(std::vector<uint8_t> &self_encoded,
4646
gsl::span<const uint8_t> input);

scripts/generate_clang_tidy_diff.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@
33
BUILD_DIR="${BUILD_DIR:?BUILD_DIR variable is not defined}"
44

55
cd "$(dirname "$0")/.."
6-
git diff -U0 HEAD^ | clang-tidy-diff.py -p1 -path "$BUILD_DIR"
6+
git diff -U0 HEAD^ | clang-tidy-diff.py -p1 -path "$BUILD_DIR"

0 commit comments

Comments
 (0)