From 035a40d70cc7efc2c39bf9779e2e88984e8d94f0 Mon Sep 17 00:00:00 2001 From: DTTerastar Date: Sun, 19 Apr 2026 21:02:22 -0400 Subject: [PATCH] ci: move release trigger to 'release: published' MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Goreleaser on tag-push was incoherent: the 'release.draft: true' flag only affected the GitHub release object, while the Homebrew tap push fired immediately — so drafts shipped broken casks pointing at assets only admins could download. New flow: - draft created by 'gh release create --draft' (or the UI) - user reviews and publishes when ready - 'release: published' event fires this workflow - goreleaser uploads assets and pushes cask atomically Also add 'skip_upload: auto' so casks are skipped for prerelease tags, and drop release-drafter (replaced by manual 'gh release create'). Co-Authored-By: Claude Opus 4.7 (1M context) --- .github/release-drafter.yml | 32 --------------------------- .github/workflows/release-drafter.yml | 17 -------------- .github/workflows/release.yml | 5 ++--- .goreleaser.yml | 3 +-- 4 files changed, 3 insertions(+), 54 deletions(-) delete mode 100644 .github/release-drafter.yml delete mode 100644 .github/workflows/release-drafter.yml diff --git a/.github/release-drafter.yml b/.github/release-drafter.yml deleted file mode 100644 index 11c9802..0000000 --- a/.github/release-drafter.yml +++ /dev/null @@ -1,32 +0,0 @@ -name-template: 'v$RESOLVED_VERSION' -tag-template: 'v$RESOLVED_VERSION' -categories: - - title: 'Features' - labels: - - 'feature' - - 'enhancement' - - title: 'Bug Fixes' - labels: - - 'fix' - - 'bugfix' - - 'bug' - - title: 'Maintenance' - labels: - - 'chore' - - 'maintenance' -change-template: '- $TITLE @$AUTHOR (#$NUMBER)' -version-resolver: - major: - labels: - - 'major' - minor: - labels: - - 'minor' - patch: - labels: - - 'patch' - default: patch -template: | - ## Changes - - $CHANGES diff --git a/.github/workflows/release-drafter.yml b/.github/workflows/release-drafter.yml deleted file mode 100644 index 036566c..0000000 --- a/.github/workflows/release-drafter.yml +++ /dev/null @@ -1,17 +0,0 @@ -name: Release Drafter - -on: - push: - branches: [main] - -permissions: - contents: write - pull-requests: write - -jobs: - update_release_draft: - runs-on: ubuntu-latest - steps: - - uses: release-drafter/release-drafter@v7 - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index fb4ed39..ccabfd4 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -1,9 +1,8 @@ name: Release on: - push: - tags: - - 'v*' + release: + types: [published] permissions: contents: write diff --git a/.goreleaser.yml b/.goreleaser.yml index 42e0c31..763e1ee 100644 --- a/.goreleaser.yml +++ b/.goreleaser.yml @@ -27,6 +27,7 @@ checksum: homebrew_casks: - name: withings-export + skip_upload: auto repository: owner: quantcli name: homebrew-tap @@ -45,6 +46,4 @@ homebrew_casks: end release: - draft: true - replace_existing_draft: true replace_existing_artifacts: true