Skip to content

Commit 3c592cc

Browse files
authored
Fix wrong unit by label indexin in Qudt (#124)
- QUDT now uses the correct trie prefix for labels when indexing units - Adds a unit test that activated the bug prior to fixing it
1 parent 4c40a5b commit 3c592cc

2 files changed

Lines changed: 3 additions & 1 deletion

File tree

qudtlib-main/src/main/java/io/github/qudtlib/Qudt.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ private static void reindexUnitsForSearch() {
165165
.map(LangString::getString)
166166
.forEach(
167167
s -> {
168-
unitIndex.put(UNIT_INDEX_KEYS.UCUM_CODE + s, u);
168+
unitIndex.put(UNIT_INDEX_KEYS.LABEL + s, u);
169169
});
170170
}
171171
}

qudtlib-test/src/test/java/io/github/qudtlib/QudtTests.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1004,6 +1004,8 @@ private void testParseUnit(String input, QuantityKind quantityKind, Set<Unit> ex
10041004

10051005
public static Stream<Arguments> testParseUnit_specificCases() {
10061006
return Stream.of(
1007+
Arguments.of("g/Mole", QuantityKinds.MolarMass, Set.of(Units.GM__PER__MOL)),
1008+
Arguments.of("g/mole", QuantityKinds.MolarMass, Set.of(Units.GM__PER__MOL)),
10071009
Arguments.of("m", QuantityKinds.Length, Set.of(Units.M)),
10081010
Arguments.of("/h", QuantityKinds.Frequency, Set.of(Units.PER__HR)),
10091011
Arguments.of("1/h", QuantityKinds.Frequency, Set.of(Units.PER__HR)),

0 commit comments

Comments
 (0)