Merge pull request #262 from poissoncorp/RDBC-999

poissoncorp · web-flow · commit 4894faa2e8a3 · 2026-01-21T12:57:30.000+01:00
RDBC-999 VectorQuantizer should return list[int] instead of bytes for proper serialization
RDBC-991 Add 7.2 to GHA RavenDB version matrix (python)
Fixed failing tests 
Fixed 3.14 issue with "unhashable" error message
diff --git a/.github/workflows/RavenClient.yml b/.github/workflows/RavenClient.yml
@@ -25,12 +25,12 @@ jobs:
         RAVENDB_PYTHON_TEST_SERVER_CERTIFICATE_PATH: certs/server.pfx
         RAVENDB_PYTHON_TEST_CLIENT_CERTIFICATE_PATH: certs/python.pem
         RAVENDB_PYTHON_TEST_CA_PATH: /usr/local/share/ca-certificates/ca.crt
-        RAVENDB_PYTHON_TEST_HTTPS_SERVER_URL: https://localhost:7326
+        RAVENDB_PYTHON_TEST_HTTPS_SERVER_URL: https://localhost:8081
 
       strategy:
         matrix:
-          python-version: [ '3.9', '3.10' ,'3.11', '3.12']
-          serverVersion: [ '7.1' ]
+          python-version: [ '3.10' ,'3.11', '3.12', '3.13', '3.14']
+          serverVersion: [ '7.1', '7.2' ]
         fail-fast: false
 
       steps:
@@ -54,7 +54,7 @@ jobs:
 
       - run: mkdir certs
       - run: openssl genrsa -out certs/ca.key 2048
-      - run: openssl req -new -x509 -key certs/ca.key -out certs/ca.crt -subj "/C=US/ST=Arizona/L=Nevada/O=RavenDB Test CA/OU=RavenDB test CA/CN=localhost/emailAddress=ravendbca@example.com" -addext "basicConstraints = CA:TRUE" -addext "keyUsage = digitalSignature,keyCertSign"
+      - run: openssl req -new -x509 -key certs/ca.key -out certs/ca.crt -subj "/C=US/ST=Arizona/L=Nevada/O=RavenDB Test CA/OU=RavenDB test CA/CN=localhost/emailAddress=ravendbca@example.com" -addext "basicConstraints = critical, CA:TRUE" -addext "keyUsage = critical, digitalSignature, keyCertSign"
       - run: openssl genrsa -out certs/localhost.key 2048
       - run: openssl req -new  -key certs/localhost.key -out certs/localhost.csr -subj "/C=US/ST=Arizona/L=Nevada/O=RavenDB Test/OU=RavenDB test/CN=localhost/emailAddress=ravendb@example.com" -addext "subjectAltName = DNS:localhost"
       - run: openssl x509 -req -extensions ext -extfile cert/test_cert.conf -in certs/localhost.csr -CA certs/ca.crt -CAkey certs/ca.key -CAcreateserial -out certs/localhost.crt
@@ -85,11 +85,9 @@ jobs:
         run: mkdir RavenDB/Server/certs && cp certs/server.pfx RavenDB/Server/certs/
 
       - name: Install black linter
-        if: ${{ matrix.python-version != '3.7' }}
         run: pip install black
 
       - name: Check code format
-        if: ${{ matrix.python-version != '3.7' }}
         run: black --check .
 
       - name: Run tests
diff --git a/ravendb/documents/conventions.py b/ravendb/documents/conventions.py
@@ -87,6 +87,7 @@ def __init__(self):
         self.wait_for_indexes_after_save_changes_timeout = timedelta(seconds=15)
         self.wait_for_replication_after_save_changes_timeout = timedelta(seconds=15)
         self.wait_for_non_stale_results_timeout = timedelta(seconds=15)
+        self.max_empty_lines_in_jsonl_stream = 100
 
         # Balancing
         self._load_balancer_context_seed: Optional[int] = None
diff --git a/ravendb/documents/indexes/time_series.py b/ravendb/documents/indexes/time_series.py
@@ -21,7 +21,6 @@
 from ravendb.documents.indexes.spatial.configuration import SpatialOptions, SpatialOptionsFactory
 from ravendb.primitives import constants
 
-
 _T_IndexDefinition = TypeVar("_T_IndexDefinition", bound=IndexDefinition)
 
 
diff --git a/ravendb/documents/operations/ai/abstract_ai_settings.py b/ravendb/documents/operations/ai/abstract_ai_settings.py
@@ -3,8 +3,8 @@
 
 
 class AbstractAiSettings(ABC):
-    def __init__(self):
-        self.embeddings_max_concurrent_batches = None
+    def __init__(self, embeddings_max_concurrent_batches: int = None):
+        self.embeddings_max_concurrent_batches = embeddings_max_concurrent_batches
 
     @classmethod
     @abstractmethod
diff --git a/ravendb/documents/operations/ai/agents/add_or_update_ai_agent_operation.py b/ravendb/documents/operations/ai/agents/add_or_update_ai_agent_operation.py
@@ -9,7 +9,6 @@
 from ravendb.http.server_node import ServerNode
 import requests
 
-
 if TYPE_CHECKING:
     from ravendb.documents.operations.ai.agents.ai_agent_configuration import AiAgentConfiguration
 
diff --git a/ravendb/documents/operations/ai/agents/run_conversation_operation.py b/ravendb/documents/operations/ai/agents/run_conversation_operation.py
@@ -11,7 +11,6 @@
 from ravendb.http.misc import ResponseDisposeHandling
 from ravendb.documents.ai.content_part import ContentPart
 
-
 TSchema = TypeVar("TSchema")
 
 
diff --git a/ravendb/documents/operations/ai/azure_open_ai_settings.py b/ravendb/documents/operations/ai/azure_open_ai_settings.py
@@ -12,8 +12,9 @@ def __init__(
         deployment_name: str = None,
         dimensions: int = None,
         temperature: float = None,
+        embeddings_max_concurrent_batches: int = None,
     ):
-        super().__init__(api_key, endpoint, model, dimensions, temperature)
+        super().__init__(api_key, endpoint, model, dimensions, temperature, embeddings_max_concurrent_batches)
         if deployment_name is None:
             raise ValueError("deployment_name cannot be None")
         self.deployment_name = deployment_name
@@ -27,6 +28,9 @@ def from_json(cls, json_dict: Dict[str, Any]) -> "AzureOpenAiSettings":
             dimensions=json_dict["Dimensions"] if "Dimensions" in json_dict else None,
             temperature=json_dict["Temperature"] if "Temperature" in json_dict else None,
             deployment_name=json_dict["DeploymentName"] if "DeploymentName" in json_dict else None,
+            embeddings_max_concurrent_batches=(
+                json_dict["EmbeddingsMaxConcurrentBatches"] if "EmbeddingsMaxConcurrentBatches" in json_dict else None
+            ),
         )
 
     def to_json(self) -> Dict[str, Any]:
@@ -37,4 +41,5 @@ def to_json(self) -> Dict[str, Any]:
             "Dimensions": self.dimensions,
             "Temperature": self.temperature,
             "DeploymentName": self.deployment_name,
+            "EmbeddingsMaxConcurrentBatches": self.embeddings_max_concurrent_batches,
         }
diff --git a/ravendb/documents/operations/ai/embedded_settings.py b/ravendb/documents/operations/ai/embedded_settings.py
@@ -4,12 +4,18 @@
 
 
 class EmbeddedSettings(AbstractAiSettings):
-    def __init__(self):
-        super().__init__()
+    def __init__(self, embeddings_max_concurrent_batches: int = None):
+        super().__init__(embeddings_max_concurrent_batches)
 
     @classmethod
     def from_json(cls, json_dict: Dict[str, Any]) -> "EmbeddedSettings":
-        return cls()
+        return cls(
+            embeddings_max_concurrent_batches=(
+                json_dict.get("EmbeddingsMaxConcurrentBatches")
+                if json_dict.get("EmbeddingsMaxConcurrentBatches")
+                else None
+            ),
+        )
 
     def to_json(self) -> Dict[str, Any]:
         return {"EmbeddingsMaxConcurrentBatches": self.embeddings_max_concurrent_batches}
diff --git a/ravendb/documents/operations/ai/google_settings.py b/ravendb/documents/operations/ai/google_settings.py
@@ -11,9 +11,14 @@ class GoogleAiVersion(Enum):
 
 class GoogleSettings(AbstractAiSettings):
     def __init__(
-        self, model: str = None, api_key: str = None, ai_version: GoogleAiVersion = None, dimensions: int = None
+        self,
+        model: str = None,
+        api_key: str = None,
+        ai_version: GoogleAiVersion = None,
+        dimensions: int = None,
+        embeddings_max_concurrent_batches: int = None,
     ):
-        super().__init__()
+        super().__init__(embeddings_max_concurrent_batches)
         self.model = model
         self.api_key = api_key
         self.ai_version = ai_version
@@ -22,10 +27,13 @@ def __init__(
     @classmethod
     def from_json(cls, json_dict: Dict[str, Any]) -> "GoogleSettings":
         return cls(
-            model=json_dict["Model"],
-            api_key=json_dict["ApiKey"],
-            ai_version=GoogleAiVersion(json_dict["AiVersion"]),
-            dimensions=json_dict["Dimensions"],
+            model=json_dict["Model"] if "Model" in json_dict else None,
+            api_key=json_dict["ApiKey"] if "ApiKey" in json_dict else None,
+            ai_version=GoogleAiVersion(json_dict["AiVersion"]) if "AiVersion" in json_dict else None,
+            dimensions=json_dict["Dimensions"] if "Dimensions" in json_dict else None,
+            embeddings_max_concurrent_batches=(
+                json_dict["EmbeddingsMaxConcurrentBatches"] if "EmbeddingsMaxConcurrentBatches" in json_dict else None
+            ),
         )
 
     def to_json(self) -> Dict[str, Any]:
diff --git a/ravendb/documents/operations/ai/hugging_face_settings.py b/ravendb/documents/operations/ai/hugging_face_settings.py
@@ -4,18 +4,27 @@
 
 
 class HuggingFaceSettings(AbstractAiSettings):
-    def __init__(self, api_key: str = None, model: str = None, endpoint: str = None):
-        super().__init__()
+    def __init__(
+        self,
+        api_key: str = None,
+        model: str = None,
+        endpoint: str = None,
+        embeddings_max_concurrent_batches: int = None,
+    ):
+        super().__init__(embeddings_max_concurrent_batches)
         self.api_key = api_key
         self.model = model
         self.endpoint = endpoint
 
     @classmethod
     def from_json(cls, json_dict: Dict[str, Any]) -> "HuggingFaceSettings":
         return cls(
-            api_key=json_dict["ApiKey"],
-            model=json_dict["Model"],
-            endpoint=json_dict["Endpoint"],
+            api_key=json_dict["ApiKey"] if "ApiKey" in json_dict else None,
+            model=json_dict["Model"] if "Model" in json_dict else None,
+            endpoint=json_dict["Endpoint"] if "Endpoint" in json_dict else None,
+            embeddings_max_concurrent_batches=(
+                json_dict["EmbeddingsMaxConcurrentBatches"] if "EmbeddingsMaxConcurrentBatches" in json_dict else None
+            ),
         )
 
     def to_json(self) -> Dict[str, Any]:
diff --git a/ravendb/documents/operations/ai/mistral_ai_settings.py b/ravendb/documents/operations/ai/mistral_ai_settings.py
@@ -4,18 +4,27 @@
 
 
 class MistralAiSettings(AbstractAiSettings):
-    def __init__(self, api_key: str = None, model: str = None, endpoint: str = None):
-        super().__init__()
+    def __init__(
+        self,
+        api_key: str = None,
+        model: str = None,
+        endpoint: str = None,
+        embeddings_max_concurrent_batches: int = None,
+    ):
+        super().__init__(embeddings_max_concurrent_batches)
         self.api_key = api_key
         self.model = model
         self.endpoint = endpoint
 
     @classmethod
     def from_json(cls, json_dict: Dict[str, Any]) -> "MistralAiSettings":
         return cls(
-            api_key=json_dict["ApiKey"],
-            model=json_dict["Model"],
-            endpoint=json_dict["Endpoint"],
+            api_key=json_dict["ApiKey"] if "ApiKey" in json_dict else None,
+            model=json_dict["Model"] if "Model" in json_dict else None,
+            endpoint=json_dict["Endpoint"] if "Endpoint" in json_dict else None,
+            embeddings_max_concurrent_batches=(
+                json_dict["EmbeddingsMaxConcurrentBatches"] if "EmbeddingsMaxConcurrentBatches" in json_dict else None
+            ),
         )
 
     def to_json(self) -> Dict[str, Any]:
diff --git a/ravendb/documents/operations/ai/ollama_settings.py b/ravendb/documents/operations/ai/ollama_settings.py
@@ -12,12 +12,11 @@ def __init__(
         temperature: float = None,
         embeddings_max_concurrent_batches: int = None,
     ):
-        super().__init__()
+        super().__init__(embeddings_max_concurrent_batches)
         self.uri = uri
         self.model = model
         self.think = think
         self.temperature = temperature
-        self.embeddings_max_concurrent_batches = embeddings_max_concurrent_batches
 
     @classmethod
     def from_json(cls, json_dict: Dict[str, Any]) -> "OllamaSettings":
diff --git a/ravendb/documents/operations/ai/open_ai_base_settings.py b/ravendb/documents/operations/ai/open_ai_base_settings.py
@@ -11,8 +11,9 @@ def __init__(
         model: str = None,
         dimensions: int = None,
         temperature: float = None,
+        embeddings_max_concurrent_batches: int = None,
     ):
-        super().__init__()
+        super().__init__(embeddings_max_concurrent_batches)
         self.api_key = api_key
         self.endpoint = endpoint
         self.model = model
diff --git a/ravendb/documents/operations/ai/open_ai_settings.py b/ravendb/documents/operations/ai/open_ai_settings.py
@@ -13,8 +13,9 @@ def __init__(
         project_id: str = None,
         dimensions: int = None,
         temperature: float = None,
+        embeddings_max_concurrent_batches: int = None,
     ):
-        super().__init__(api_key, endpoint, model, dimensions, temperature)
+        super().__init__(api_key, endpoint, model, dimensions, temperature, embeddings_max_concurrent_batches)
         self.organization_id = organization_id
         self.project_id = project_id
 
@@ -28,6 +29,9 @@ def from_json(cls, json_dict: Dict[str, Any]) -> "OpenAiSettings":
             temperature=json_dict["Temperature"] if "Temperature" in json_dict else None,
             organization_id=json_dict["OrganizationId"] if "OrganizationId" in json_dict else None,
             project_id=json_dict["ProjectId"] if "ProjectId" in json_dict else None,
+            embeddings_max_concurrent_batches=(
+                json_dict["EmbeddingsMaxConcurrentBatches"] if "EmbeddingsMaxConcurrentBatches" in json_dict else None
+            ),
         )
 
     def to_json(self) -> Dict[str, Any]:
diff --git a/ravendb/documents/operations/ai/vertex_settings.py b/ravendb/documents/operations/ai/vertex_settings.py
@@ -16,8 +16,9 @@ def __init__(
         google_credentials_json: Optional[str] = None,
         location: Optional[str] = None,
         ai_version: Optional[VertexAIVersion] = None,
+        embeddings_max_concurrent_batches: Optional[int] = None,
     ):
-        super().__init__()
+        super().__init__(embeddings_max_concurrent_batches)
         self.model = model
         self.google_credentials_json = google_credentials_json
         self.location = location
@@ -30,6 +31,11 @@ def from_json(cls, json_dict: Dict[str, Any]) -> "VertexSettings":
             google_credentials_json=json_dict.get("GoogleCredentialsJson"),
             location=json_dict.get("Location"),
             ai_version=VertexAIVersion(json_dict["AiVersion"]) if json_dict.get("AiVersion") else None,
+            embeddings_max_concurrent_batches=(
+                json_dict.get("EmbeddingsMaxConcurrentBatches")
+                if json_dict.get("EmbeddingsMaxConcurrentBatches")
+                else None
+            ),
         )
 
     def to_json(self) -> Dict[str, Any]:
diff --git a/ravendb/documents/operations/etl/configuration.py b/ravendb/documents/operations/etl/configuration.py
@@ -7,7 +7,6 @@
 from ravendb.documents.operations.etl.transformation import Transformation
 import ravendb.serverwide.server_operation_executor
 
-
 _T = TypeVar("_T", bound=ConnectionString)
 
 
diff --git a/ravendb/documents/operations/ongoing_tasks.py b/ravendb/documents/operations/ongoing_tasks.py
@@ -365,7 +365,9 @@ def get_raft_unique_request_id(self) -> str:
             return RaftIdGenerator.new_id()
 
 
-class GetOngoingTaskInfoOperation(MaintenanceOperation[OngoingTask]):
+class GetOngoingTaskInfoOperation(
+    MaintenanceOperation[Union[OngoingTask, OngoingTaskGenAi, OngoingTaskEmbeddingsGeneration]]
+):
     """
     Operation to retrieve detailed information about a specific ongoing task.
     Ongoing tasks include various types of tasks such as replication, ETL, backup, and subscriptions.
@@ -398,14 +400,16 @@ def __init__(self, task_id_or_name: Union[int, str], task_type: OngoingTaskType)
 
         self._task_type = task_type
 
-    def get_command(self, conventions: "DocumentConventions") -> RavenCommand[OngoingTask]:
+    def get_command(
+        self, conventions: "DocumentConventions"
+    ) -> RavenCommand[OngoingTask | OngoingTaskGenAi | OngoingTaskEmbeddingsGeneration]:
         if self._task_name is not None:
             return GetOngoingTaskInfoOperation._GetOngoingTaskInfoCommand(
                 task_name=self._task_name, task_type=self._task_type
             )
         return GetOngoingTaskInfoOperation._GetOngoingTaskInfoCommand(task_id=self._task_id, task_type=self._task_type)
 
-    class _GetOngoingTaskInfoCommand(RavenCommand[OngoingTask]):
+    class _GetOngoingTaskInfoCommand(RavenCommand[OngoingTask | OngoingTaskGenAi | OngoingTaskEmbeddingsGeneration]):
         def __init__(
             self,
             task_type: OngoingTaskType,
@@ -432,7 +436,9 @@ def set_response(self, response: Optional[str], from_cache: bool) -> None:
                 json_dict = json.loads(response)
                 self.result = self._deserialize_task(json_dict)
 
-        def _deserialize_task(self, json_dict: dict) -> OngoingTask:
+        def _deserialize_task(
+            self, json_dict: dict
+        ) -> OngoingTask | OngoingTaskGenAi | OngoingTaskEmbeddingsGeneration:
             """Deserialize the task based on its type."""
             if self._task_type == OngoingTaskType.GEN_AI:
                 return OngoingTaskGenAi.from_json(json_dict)
diff --git a/ravendb/documents/operations/revisions.py b/ravendb/documents/operations/revisions.py
@@ -15,7 +15,6 @@
 from ravendb.documents.session.entity_to_json import EntityToJsonStatic
 from ravendb.documents.conventions import DocumentConventions
 
-
 if TYPE_CHECKING:
     from ravendb.http.http_cache import HttpCache
     from ravendb import DocumentStore, ServerNode
diff --git a/ravendb/documents/queries/more_like_this.py b/ravendb/documents/queries/more_like_this.py
@@ -6,7 +6,6 @@
 from ravendb.primitives import constants
 from ravendb.documents.session.tokens.query_tokens.definitions import MoreLikeThisToken
 
-
 _T = TypeVar("_T")
 
 if TYPE_CHECKING:
diff --git a/ravendb/documents/queries/vector.py b/ravendb/documents/queries/vector.py
diff --git a/ravendb/documents/session/document_session_operations/in_memory_document_session_operations.py b/ravendb/documents/session/document_session_operations/in_memory_document_session_operations.py
diff --git a/ravendb/documents/session/operations/stream.py b/ravendb/documents/session/operations/stream.py
diff --git a/ravendb/documents/session/tokens/query_tokens/definitions.py b/ravendb/documents/session/tokens/query_tokens/definitions.py
diff --git a/ravendb/serverwide/operations/common.py b/ravendb/serverwide/operations/common.py
diff --git a/ravendb/serverwide/operations/configuration.py b/ravendb/serverwide/operations/configuration.py
diff --git a/ravendb/tests/documents_tests/query_tests/test_vector_search.py b/ravendb/tests/documents_tests/query_tests/test_vector_search.py
diff --git a/ravendb/tests/jvm_migrated_tests/issues_tests/test_ravenDB_16328.py b/ravendb/tests/jvm_migrated_tests/issues_tests/test_ravenDB_16328.py
diff --git a/ravendb/tools/parsers.py b/ravendb/tools/parsers.py
