Skip to content

Commit 2d16d2d

Browse files
fix: return distinct not-found errors for each principal type
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent cb9649e commit 2d16d2d

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

internal/api/v1beta1connect/project.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -384,8 +384,12 @@ func (h *ConnectHandler) SetProjectMemberRole(ctx context.Context, request *conn
384384
switch {
385385
case errors.Is(err, project.ErrNotExist):
386386
return nil, connect.NewError(connect.CodeNotFound, ErrNotFound)
387-
case errors.Is(err, user.ErrNotExist), errors.Is(err, serviceuser.ErrNotExist), errors.Is(err, group.ErrNotExist):
388-
return nil, connect.NewError(connect.CodeNotFound, ErrNotFound)
387+
case errors.Is(err, user.ErrNotExist):
388+
return nil, connect.NewError(connect.CodeNotFound, ErrUserNotExist)
389+
case errors.Is(err, serviceuser.ErrNotExist):
390+
return nil, connect.NewError(connect.CodeNotFound, ErrServiceUserNotFound)
391+
case errors.Is(err, group.ErrNotExist):
392+
return nil, connect.NewError(connect.CodeNotFound, ErrGroupNotFound)
389393
case errors.Is(err, project.ErrNotOrgMember):
390394
return nil, connect.NewError(connect.CodeFailedPrecondition, ErrNotMember)
391395
case errors.Is(err, role.ErrNotExist):

0 commit comments

Comments
 (0)