Fix bug with unclosed html element in discopower

olgabrani · olgabrani · commit 477301be65da · 2019-09-12T12:47:27.000Z
diff --git a/themes/ssp/discopower/disco-tpl.php b/themes/ssp/discopower/disco-tpl.php
@@ -83,8 +83,9 @@ function showEntry($t, $metadata, $favourite = FALSE, $withIcon = FALSE) {
     $html = '<a class="metaentry ssp-btn ' . $css_button_type  .  ' ' . $css_classname . '" href="' . $basequerystring . urlencode($metadata['entityid']) . '">';
     $html .= '<img alt="Identity Provider" class="entryicon" src="' . SimpleSAML_Module::getModuleURL('themevanilla/resources/images/' . $filename ) . '" />';
     if (isset($label)) {
-        $html .= '<span>' . $label . '</span></a>';
+        $html .= '<span>' . $label . '</span>';
     }
+    $html .= '</a>';
   }
   else {
     $html = '<a class="metaentry " href="' . $basequerystring . urlencode($metadata['entityid']) . '">';

Original file line number	Diff line number	Diff line change
`@@ -83,8 +83,9 @@ function showEntry($t, $metadata, $favourite = FALSE, $withIcon = FALSE) {`
`83`	`83`	`$html = '<a class="metaentry ssp-btn ' . $css_button_type . ' ' . $css_classname . '" href="' . $basequerystring . urlencode($metadata['entityid']) . '">';`
`84`	`84`	`$html .= '<img alt="Identity Provider" class="entryicon" src="' . SimpleSAML_Module::getModuleURL('themevanilla/resources/images/' . $filename ) . '" />';`
`85`	`85`	`if (isset($label)) {`
`86`		`- $html .= '<span>' . $label . '</span></a>';`
	`86`	`+ $html .= '<span>' . $label . '</span>';`
`87`	`87`	`}`
	`88`	`+ $html .= '</a>';`
`88`	`89`	`}`
`89`	`90`	`else {`
`90`	`91`	`$html = '<a class="metaentry " href="' . $basequerystring . urlencode($metadata['entityid']) . '">';`