[Discopower] Move ribbon_text option to config file

Author: nikosev

README.md

@@ -202,7 +202,7 @@ If you want to make any changes in the footer you need to modify the template
 ### Header ribbon
 
 The text in the header ribbon can be altered by changing the `ribbon_text`
-definition in `dictionaries/default.definition.json` file.
+definition in `module_themevanilla.php` file.
 If you want to hide the ribbon, set `ribbon_text` to `""`.
 
 ### CSS

config-example/module_themevanilla.php

@@ -1,11 +1,13 @@
 <?php
+
 /**
  * This is example configuration of SimpleSAMLphp themevanila.
  * Copy this file to default config directory and edit the properties.
  *
  * copy command (from SimpleSAML base dir)
  * cp modules/themevanilla/module_themevanilla.php config/
  */
+
 $config = array(
     'cookiePolicy' => array(
         array('type' => 'Session State', 'provider' => 'aai.rciam.eu', 'name' => 'rciam_proxy_authtoken, rciam_google_proxy_authtoken, rciam_google_proxy_authtoken, rciam_facebook_proxy_authtoken, rciam_linkedin_proxy_authtoken, rciam_orcid_proxy_authtoken', 'thirdParty' => false, 'category' => 'Session', 'purpose' => 'Preserve user authentication token to prevent session fixation attacks'),
@@ -17,7 +19,6 @@
         array('type' => 'Preferences', 'provider' => 'aai.rciam.eu', 'name' => 'i18next', 'thirdParty' => false, 'category' => 'Session', 'purpose' => 'Preserve preferred language for RCIAM AAI OpenID Connect Provider'),
         array('type' => 'Session State', 'provider' => 'aai.rciam.eu', 'name' => 'JSESSIONID', 'thirdParty' => false, 'category' => 'Session', 'purpose' => 'Preserve user session ID to retrieve session information')
       ),
-      'enable_cookies_banner' => false
+      'enable_cookies_banner' => false,
+      'ribbon_text' => '',
 );
-
-?>

dictionaries/default.definition.json

@@ -10,8 +10,5 @@
   },
   "logo_link_url": {
     "en": "https://www.example.com"
-  },
-  "ribbon_text": {
-    "en": "Demo"
   }
 }

themes/ssp/default/includes/header.php

@@ -1,6 +1,7 @@
 <?php
 
-
+$themeConfig = SimpleSAML\Configuration::getConfig('module_themevanilla.php');
+$ribbonText = $themeConfig->getValue('ribbon_text');
 
 /**
  * Support the htmlinject hook, which allows modules to change header, pre and post body on all pages.
@@ -127,9 +128,9 @@
 
 <div class="header">
 <?php
-  if (strpos($this->t('{themevanilla:default:ribbon_text}'), 'not translated') === FALSE || $this->t('{themevanilla:default:ribbon_text}')) {
+  if (!empty($ribbonText)) {
     echo '<div class="corner-ribbon red">';
-    echo $this->t('{themevanilla:default:ribbon_text}');
+    echo $ribbonText;
     echo '</div>';
   }
   ?>