Improve UX when changing lexer properties

Unsetting the global 'fold' property still requires reloading, a
potentially destructive action, so just warn the user instead

Also drops a redundant save action from the config manager's destructor

Author: rdipardo

Source/Plugin/Forms/ConfigForm.pas

@@ -164,12 +164,12 @@ procedure TFrmConfiguration.initialize;
   chkEchoText.Checked := _config.EchoNPPTextInEditor;
   with TLexerProperties do
   begin
-    chkFolding.Checked := Fold;
     chkFoldCompact.Checked := FoldCompact;
     chkFoldComments.Checked := FoldComments;
     chkFoldMultiLineComments.Checked := FoldMultiLineComments;
     chkFoldOpenStatements.Checked := FoldOpenStatements;
     chkFoldPreprocessor.Checked := FoldPreprocessor;
+    chkFolding.Checked := Fold;
   end;
 
   toggleFoldOptions;

Source/Plugin/Src/Config.pas

@@ -33,18 +33,21 @@ interface
 
 type
 
+  TPropertyInt = Boolean;
+
   /// <summary>
   /// Stores, retrieves and manages configuration for the plugin.
   /// </summary>
   TConfiguration = class
   private
     _configFile: WideString;
-    _useDotnet: Boolean;
+    _useDotnet: TPropertyInt;
     _fsiPath: String;
     _fsiArgs: String;
-    _convertTabsToSpacesInFSIEditor: Boolean;
+    _convertTabsToSpacesInFSIEditor: TPropertyInt;
     _tabLength: Integer;
-    _echoNPPTextInEditor: Boolean;
+    _echoNPPTextInEditor: TPropertyInt;
+    _initialFoldState: TPropertyInt;
   private
     procedure initializeConfiguration;
   public
@@ -63,8 +66,6 @@   TConfiguration = class
     property EchoNPPTextInEditor: Boolean read _echoNPPTextInEditor write _echoNPPTextInEditor;
   end;
 
-  TPropertyInt = Boolean;
-
   TLexerProperties = class
   private
     class function GetXMLConfig: WideString; static;
@@ -111,8 +112,6 @@ constructor TConfiguration.Create;
 
 destructor TConfiguration.Destroy;
 begin
-  SaveToConfigFile;
-
   inherited;
 end;
 
@@ -139,6 +138,7 @@ procedure TConfiguration.LoadFromConfigFile;
     end;
   end;
   TLexerProperties.LoadProperties;
+  _initialFoldState := TLexerProperties.Fold;
 end;
 
 procedure TConfiguration.SaveToConfigFile;
@@ -157,6 +157,10 @@ procedure TConfiguration.SaveToConfigFile;
   finally
     configINI.Free;
   end;
+  TLexerProperties.SetLexer;
+  if (_initialFoldState = True) and (not TLexerProperties.Fold) then
+    MessageBoxW(NppData._nppHandle, PWchar('Reload F# files to apply changes.'),
+      PWchar('File Reload Required'), MB_ICONINFORMATION);
 end;
 
 {$ENDREGION}