Skip to content

Commit e79bcce

Browse files
fix(Select): fix label not hiding when visibility is set to hidden (#1194)
* fix(Select): fix label not hiding when visibility is set to hidden * fix: test * fix: select test issue
1 parent d1aeb03 commit e79bcce

2 files changed

Lines changed: 5 additions & 8 deletions

File tree

src/SelectInput/Content/SingleContent.tsx

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,11 @@ const SingleContent = React.forwardRef<HTMLInputElement, SharedContentProps>(
3333
const optionProps = React.useMemo(() => {
3434
const restProps: React.HTMLAttributes<HTMLDivElement> = {
3535
className: `${prefixCls}-content-value`,
36-
style: {
37-
visibility: mergedSearchValue ? 'hidden' : 'visible',
38-
},
36+
style: mergedSearchValue
37+
? {
38+
visibility: 'hidden',
39+
}
40+
: {},
3941
};
4042

4143
if (displayValue && selectContext?.flattenOptions) {

tests/__snapshots__/Select.test.tsx.snap

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,6 @@ exports[`Select.Basic render renders aria-attributes correctly 1`] = `
115115
>
116116
<div
117117
class="antd-content-value"
118-
style="visibility: visible;"
119118
title="2"
120119
>
121120
2
@@ -151,7 +150,6 @@ exports[`Select.Basic render renders correctly 1`] = `
151150
>
152151
<div
153152
class="antd-content-value"
154-
style="visibility: visible;"
155153
title="2"
156154
>
157155
2
@@ -187,7 +185,6 @@ exports[`Select.Basic render renders data-attributes correctly 1`] = `
187185
>
188186
<div
189187
class="antd-content-value"
190-
style="visibility: visible;"
191188
title="2"
192189
>
193190
2
@@ -221,7 +218,6 @@ exports[`Select.Basic render renders disabled select correctly 1`] = `
221218
>
222219
<div
223220
class="antd-content-value"
224-
style="visibility: visible;"
225221
title="2"
226222
>
227223
2
@@ -253,7 +249,6 @@ exports[`Select.Basic render renders role prop correctly 1`] = `
253249
>
254250
<div
255251
class="antd-content-value"
256-
style="visibility: visible;"
257252
title="2"
258253
>
259254
2

0 commit comments

Comments
 (0)