fix: update tests to validate status

Author: lmeireles

.idea/.gitignore

@@ -7,8 +7,8 @@ defmodule ApiEcommerce.Auth.User do
   schema "users" do
     field :name, :string
     field :email, :string
-    field :role, RoleEnum, default: 0
-    field :status, StatusEnum, default: 0
+    field :role, RoleEnum, default: :member
+    field :status, StatusEnum, default: :active
     field :recovery_token, :string
     field :recovery_token_created_at, :naive_datetime
     field :password_hash, :string
@@ -21,8 +21,8 @@ defmodule ApiEcommerce.Auth.User do
   @doc false
   def changeset(user, attrs) do
     user
-    |> cast(attrs, [:name, :email, :status, :role, :password])
-    |> validate_required([:email, :status, :role, :password])
+    |> cast(attrs, [:name, :email, :status, :role, :password, :password_confirmation])
+    |> validate_required([:email, :status, :role, :password, :password_confirmation])
     |> validate_format(:email, ~r/@/)
     |> validate_length(:password, min: 6)
     |> validate_confirmation(:password) # Check that password === password_confirmation
@@ -31,7 +31,9 @@ defmodule ApiEcommerce.Auth.User do
   end
 
   defp put_password_hash(%Ecto.Changeset{valid?: true, changes: %{password: password}} = changeset) do
-    change(changeset, Bcrypt.add_hash(password))
+    changeset
+    |> change(Bcrypt.add_hash(password))
+    |> change(%{password_confirmation: nil})
   end
 
   defp put_password_hash(changeset) do

.idea/dataSources.xml

@@ -18,6 +18,6 @@ defmodule ApiEcommerceWeb.UserView do
   end
 
   def render("user.json", %{user: user}) do
-    %{id: user.id, email: user.email, is_active: user.is_active}
+    %{id: user.id, email: user.email, status: user.status}
   end
 end

lib/api_ecommerce/auth/user.ex

@@ -7,14 +7,18 @@ defmodule ApiEcommerce.AuthTest do
     alias ApiEcommerce.Auth.User
 
     @valid_attrs %{
+      name: "some name",
       email: "some@email",
-      is_active: true,
+      status: :active,
+      role: :member,
       password: "some password",
       password_confirmation: "some password"
     }
     @update_attrs %{
+      name: "some updated name",
       email: "some@updated.email",
-      is_active: false,
+      status: :deleted,
+      role: :admin,
       password: "some updated password",
       password_confirmation: "some updated password"
     }
@@ -41,8 +45,10 @@ defmodule ApiEcommerce.AuthTest do
 
     test "create_user/1 with valid data creates a user" do
       assert {:ok, %User{} = user} = Auth.create_user(@valid_attrs)
+      assert user.name == @valid_attrs.name
       assert user.email == @valid_attrs.email
-      assert user.is_active == @valid_attrs.is_active
+      assert user.status == @valid_attrs.status
+      assert user.role == @valid_attrs.role
       assert Bcrypt.verify_pass(@valid_attrs.password, user.password_hash)
     end
 
@@ -53,8 +59,10 @@ defmodule ApiEcommerce.AuthTest do
     test "update_user/2 with valid data updates the user" do
       user = user_fixture()
       assert {:ok, %User{} = user} = Auth.update_user(user, @update_attrs)
+      assert user.name == @update_attrs.name
       assert user.email == @update_attrs.email
-      assert user.is_active == @update_attrs.is_active
+      assert user.status == @update_attrs.status
+      assert user.role == @update_attrs.role
       assert Bcrypt.verify_pass(@update_attrs.password, user.password_hash)
     end
 
@@ -80,7 +88,7 @@ defmodule ApiEcommerce.AuthTest do
       user = user_fixture()
       assert {:error, "Wrong username or password"} = Auth.authenticate_user("wrong email", "")
       assert {:ok, authenticated_user} = Auth.authenticate_user(user.email, @valid_attrs.password)
-      assert %{user | password: nil} == authenticated_user
+      assert %{user | password: nil, password_confirmation: nil} == authenticated_user
     end
   end
 end

lib/api_ecommerce_web/views/user_view.ex

@@ -6,21 +6,19 @@ defmodule ApiEcommerceWeb.UserControllerTest do
 
   @create_attrs %{
     email: "some@email",
-    is_active: true,
     password: "some password",
     password_confirmation: "some password"
   }
   @update_attrs %{
     email: "some@updated.email",
-    is_active: false,
     password: "some updated password",
     password_confirmation: "some updated password"
   }
   @invalid_attrs %{email: nil, is_active: nil, password: nil}
   @current_user_attrs %{
     email: "some_current@user.email",
-    is_active: true,
-    password: "some current user password"
+    password: "some current user password",
+    password_confirmation: "some current user password"
   }
 
   def fixture(:user) do
@@ -45,7 +43,7 @@ defmodule ApiEcommerceWeb.UserControllerTest do
                %{
                  "id" => current_user.id,
                  "email" => current_user.email,
-                 "is_active" => current_user.is_active
+                 "status" => current_user.status |> Atom.to_string()
                }
              ]
     end
@@ -61,7 +59,7 @@ defmodule ApiEcommerceWeb.UserControllerTest do
       assert json_response(conn, 200)["data"] == %{
                "id" => id,
                "email" => @create_attrs.email,
-               "is_active" => @create_attrs.is_active,
+               "status" => "active",
              }
     end
 
@@ -83,7 +81,7 @@ defmodule ApiEcommerceWeb.UserControllerTest do
       assert json_response(conn, 200)["data"] == %{
                "id" => id,
                "email" => @update_attrs.email,
-               "is_active" => @update_attrs.is_active
+               "status" => user.status |> Atom.to_string()
              }
     end
 
@@ -113,7 +111,7 @@ defmodule ApiEcommerceWeb.UserControllerTest do
 
       assert json_response(conn, 200)["data"] == %{
                "id" => current_user.id,
-               "is_active" => current_user.is_active,
+               "status" => current_user.status |> Atom.to_string(),
                "email" => current_user.email}
     end