Skip to content

Rules.Idomatic: update switch for new macro enumerator#5142

Closed
compnerd wants to merge 1 commit into
realm:mainfrom
compnerd:macro
Closed

Rules.Idomatic: update switch for new macro enumerator#5142
compnerd wants to merge 1 commit into
realm:mainfrom
compnerd:macro

Conversation

@compnerd

Copy link
Copy Markdown
Contributor

The introduction of the macro enumerator in the enumeration causes a build break due to an uncovered switch. Conservatively treat the macros as being exempt from the ACLing.

The introduction of the `macro` enumerator in the enumeration causes a
build break due to an uncovered switch.  Conservatively treat the macros
as being exempt from the ACLing.
@SwiftLintBot

Copy link
Copy Markdown
1 Error
🚫 Could not build branch
1 Warning
⚠️ If this is a user-facing change, please include a CHANGELOG entry to credit yourself!
You can find it at CHANGELOG.md.

Here's an example of your CHANGELOG entry:

* Rules.Idomatic: update switch for new `macro` enumerator.  
  [compnerd](https://github.com/compnerd)
  [#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)

note: There are two invisible spaces after the entry's text.

Generated by 🚫 Danger

@SimplyDanny

SimplyDanny commented Dec 17, 2023

Copy link
Copy Markdown
Collaborator

I think this is no longer required with the SwiftSyntax rewrite in #5382.

Thank you nevertheless, @compnerd!

@compnerd compnerd deleted the macro branch December 17, 2023 20:48
@compnerd

Copy link
Copy Markdown
Contributor Author

@SimplyDanny sounds good! BTW, I wouldn't mind some early feedback on #5030 (I'm happy to split that into separate PRs, but want to gauge the interest and any easy things that can be addressed up front).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants