fix: resolve test failure from arg_required_else_help and clippy warnings

- Move "show help on no subcommand" logic from clap attribute to main()
  to avoid Cli::parse() calling exit() during tests
- Fix 27 uninlined_format_args clippy warnings across the codebase

Author: realfresh

src/cli.rs

@@ -19,7 +19,7 @@ You can also browse the available templates at the GitHub &
 TopTal collections using the `search` command.";
 
 #[derive(Parser, Debug)]
-#[command(author, version, about, long_about = LONG_ABOUT, arg_required_else_help = true)]
+#[command(author, version, about, long_about = LONG_ABOUT)]
 pub struct Cli {
     /// Refresh the cache (templates are cached for 1h)
     #[arg(short = 'r', long = "refresh", global = true)]

src/commands/create.rs

@@ -72,7 +72,7 @@ pub fn command(cmd: &CommandCreate) -> Result<()> {
     }
 
     // Print template to stdout
-    println!("{}", output);
+    println!("{output}");
 
     Ok(())
 }

src/commands/search/handlers.rs

@@ -209,7 +209,7 @@ pub fn handle_mouse_events(event: MouseEvent, app: &mut UIState) -> Result<()> {
             MouseEventKind::ScrollDown => {
                 if now.duration_since(app.last_scroll_time) > Duration::from_millis(15) {
                     app.list_next(if is_shift || is_alt {
-                        println!("Scrolling {} {}", is_shift, is_alt);
+                        println!("Scrolling {is_shift} {is_alt}");
                         Some(10)
                     } else {
                         Some(1)

src/commands/search/views/home/header.rs

@@ -10,7 +10,7 @@ use ratatui::{text, Frame};
 fn create_tabs<'a>(tab_titles: Vec<String>, list_tab: usize) -> anyhow::Result<Tabs<'a>> {
     let items = tab_titles
         .into_iter()
-        .map(|t| Line::from(format!(" {} ", t)))
+        .map(|t| Line::from(format!(" {t} ")))
         .collect::<Vec<Line>>();
     let block = Block::default()
         .borders(Borders::ALL)

src/commands/search/views/home/main_side.rs

@@ -36,7 +36,7 @@ fn create_selected<'a>(
         .map(|s| {
             let name = s.template.value.name().unwrap();
             let prefix = s.kind.name();
-            ListItem::new(format!("{} - {}", prefix, name))
+            ListItem::new(format!("{prefix} - {name}"))
         })
         .collect();
 

src/main.rs

@@ -10,7 +10,7 @@ use crate::cli::{get_cli, Commands};
 use crate::commands::completions;
 use crate::commands::create;
 use crate::commands::search;
-use anyhow::{anyhow, Result};
+use anyhow::Result;
 use indoc::eprintdoc;
 use yansi::Paint;
 
@@ -22,7 +22,11 @@ fn main() -> Result<()> {
         Some(Commands::Create(cmd)) => create::command(cmd),
         Some(Commands::Search) => search::command(),
         Some(Commands::Completions { shell }) => completions::command(shell),
-        None => Err(anyhow!("No command specified")),
+        None => {
+            use clap::CommandFactory;
+            crate::cli::Cli::command().print_help()?;
+            Ok(())
+        }
     };
 
     // Handle error output and program termination

src/template/collection/github.rs

@@ -81,17 +81,17 @@ impl GithubTemplates {
 
             // Root template
             if !path.contains('/') {
-                let template = Template::new(&format!("gh:{}", path))?;
+                let template = Template::new(&format!("gh:{path}"))?;
                 root.push(template);
             }
             // Global template
             else if let Some(path) = path.strip_prefix("Global/") {
-                let template = Template::new(&format!("ghg:{}", path))?;
+                let template = Template::new(&format!("ghg:{path}"))?;
                 global.push(template);
             }
             // Community template
             else if let Some(path) = path.strip_prefix("community/") {
-                let template = Template::new(&format!("ghc:{}", path))?;
+                let template = Template::new(&format!("ghc:{path}"))?;
                 community.push(template);
             }
         }
@@ -165,24 +165,23 @@ pub struct TreeItem {
 /// Get the GitHub tree for a repository
 pub fn gh_tree(owner: &str, repo: &str, branch: &str, recursive: bool) -> Result<Tree> {
     let mut url = format!(
-        "{}/repos/{owner}/{repo}/git/trees/{branch}",
-        GITHUB_API_ENDPOINT
+        "{GITHUB_API_ENDPOINT}/repos/{owner}/{repo}/git/trees/{branch}"
     );
 
     if recursive {
-        url = format!("{}?recursive=true", url)
+        url = format!("{url}?recursive=true")
     }
 
     let res = http()
         .get(&url)
         .set("Accept", GITHUB_API_ACCEPT)
         .call()
-        .with_context(|| format!("GitHub API error when fetching repo tree\n\n{}", url))?
+        .with_context(|| format!("GitHub API error when fetching repo tree\n\n{url}"))?
         .into_string()
-        .with_context(|| format!("Failed to parse GitHub API response to string\n\n{}", url))?;
+        .with_context(|| format!("Failed to parse GitHub API response to string\n\n{url}"))?;
 
     let parsed = serde_json::from_str(&res)
-        .with_context(|| format!("Failed to parse GitHub API response to JSON\n\n{}", url))?;
+        .with_context(|| format!("Failed to parse GitHub API response to JSON\n\n{url}"))?;
 
     Ok(parsed)
 }

src/template/collection/toptal.rs

@@ -50,7 +50,7 @@ impl TopTalTemplates {
 
     /// Fetch the templates from the TopTal API
     fn fetch() -> Result<Self> {
-        let url = format!("{}/list?format=lines", TOPTAL_API);
+        let url = format!("{TOPTAL_API}/list?format=lines");
 
         let list = http()
             .get(&url)
@@ -61,7 +61,7 @@ impl TopTalTemplates {
 
         let templates = list
             .lines()
-            .map(|s| Template::new(&format!("tt:{}", s)))
+            .map(|s| Template::new(&format!("tt:{s}")))
             .collect::<Result<Vec<Template>>>()?;
 
         let updated = SystemTime::now();

src/template/item/mod.rs

@@ -128,7 +128,7 @@ impl TemplateValue {
             Self::Url(_) => {
                 let url = self.name()?;
                 let url = Url::parse(&url)
-                    .with_context(|| format!("[Ignore Template] Invalid URL: {}", url))?;
+                    .with_context(|| format!("[Ignore Template] Invalid URL: {url}"))?;
                 Ok(url.to_string())
             }
             Self::File(_) => {
@@ -143,33 +143,31 @@ impl TemplateValue {
             }
             Self::GitHubRepo(_) => {
                 let repo = self.name()?;
-                let url = format!("{}/{}", GITHUB_RAW, repo);
+                let url = format!("{GITHUB_RAW}/{repo}");
                 Ok(url)
             }
             Self::GitHubGlobal(_) => {
                 let repo = self.name()?;
                 let url = format!(
-                    "{}/github/gitignore/main/Global/{}.gitignore",
-                    GITHUB_RAW, repo
+                    "{GITHUB_RAW}/github/gitignore/main/Global/{repo}.gitignore"
                 );
                 Ok(url)
             }
             Self::GitHubCommunity(_) => {
                 let repo = self.name()?;
                 let url = format!(
-                    "{}/github/gitignore/main/community/{}.gitignore",
-                    GITHUB_RAW, repo
+                    "{GITHUB_RAW}/github/gitignore/main/community/{repo}.gitignore"
                 );
                 Ok(url)
             }
             Self::GitHub(_) => {
                 let repo = self.name()?;
-                let url = format!("{}/github/gitignore/main/{}.gitignore", GITHUB_RAW, repo);
+                let url = format!("{GITHUB_RAW}/github/gitignore/main/{repo}.gitignore");
                 Ok(url)
             }
             Self::TopTal(_) => {
                 let name = self.name()?;
-                let url = format!("{}/{}", TOPTAL_API, name);
+                let url = format!("{TOPTAL_API}/{name}");
                 Ok(url)
             }
         }
@@ -217,7 +215,7 @@ impl Template {
             TemplateValue::File(_) => {
                 let path = self.value.url()?;
                 let content = fs::read_to_string(&path).with_context(|| {
-                    format!("Failed to read ignore file template at path\n{}", path)
+                    format!("Failed to read ignore file template at path\n{path}")
                 })?;
                 Ok(content)
             }
@@ -229,11 +227,11 @@ impl Template {
                         let content: String = http().get(&url)
                             .call()
                             .with_context(|| {
-                                format!("Failed to fetch ignore template at URL. The template might not exist...\n{}", url)
+                                format!("Failed to fetch ignore template at URL. The template might not exist...\n{url}")
                             })?
                             .into_string()
                             .with_context(|| {
-                                format!("Failed to parse response when fetching ignore template at URL\n{}", url)
+                                format!("Failed to parse response when fetching ignore template at URL\n{url}")
                             })?;
                         let content = content.trim();
                         TemplateCache::set(&url, content)?;

src/template/list.rs

@@ -75,6 +75,6 @@ impl TemplateList {
 
         let cmds = cmds.join(" ");
 
-        Ok(format!("gitnr create {}", cmds).trim().to_string())
+        Ok(format!("gitnr create {cmds}").trim().to_string())
     }
 }