Update bibliographic item identifiers and enhance test isolation

Author: andrew2net

lib/relaton/bibdata.rb

@@ -13,7 +13,7 @@ def initialize(bibitem)
     end
 
     def docidentifier
-      @bibitem.docidentifier.first&.content
+      @bibitem.docidentifier.first&.content&.to_s
     end
 
     # def doctype

spec/acceptance/relaton_fetch_spec.rb

@@ -95,6 +95,8 @@
 
     context do
       let(:io) { double "IO" }
+      let(:tmpdir) { Dir.mktmpdir("relaton_test_cache") }
+
       before (:each) do
         RSpec::Mocks.space.proxy_for(IO).reset
         expect(IO).to receive(:new) do |arg1, arg2, &block|
@@ -103,12 +105,21 @@
           end
         end.at_most(2).times
 
+        # Isolate from global cache by using a fresh DB in a temp directory
+        Relaton::Cli::RelatonDb.instance.instance_variable_set(:@db, nil)
+        Relaton::Cli.relaton(tmpdir)
+
         # Force to download index file
         require "relaton/index"
         allow_any_instance_of(Relaton::Index::Type).to receive(:actual?).and_return(false)
         allow_any_instance_of(Relaton::Index::FileIO).to receive(:check_file).and_return(nil)
       end
 
+      after(:each) do
+        Relaton::Cli::RelatonDb.instance.instance_variable_set(:@db, nil)
+        FileUtils.remove_entry(tmpdir)
+      end
+
       it "calls fetch and return XML" do
         expect(io).to receive(:puts) do |arg|
           expect(arg).to match(/^<bibdata type="standard" schema-version="v\d\.\d\.\d">/)

spec/fixtures/bib_item.xml

@@ -1,4 +1,4 @@
-<bibitem id="ISOTC211" type="standard">
+<bibitem id="ISO55000" type="standard">
   <fetched>2020-07-04</fetched>
   <title type="title-main" format="text/plain">Geographic information</title>
   <title type="main" format="text/plain">Geographic information</title>
@@ -8,10 +8,7 @@
   <uri type="rss">https://www.iso.org/contents/data/standard/05/37/53798.detail.rss</uri>
   <uri type="doi">http://standrd.org/doi-123</uri>
   <uri type="file">file://path/file</uri>
-  <docidentifier primary="true" type="ISO">TC211</docidentifier>
-  <docidentifier type="isbn">ISBN</docidentifier>
-  <docidentifier type="lccn">LCCN</docidentifier>
-  <docidentifier type="issn" scope="series">ISSN</docidentifier>
+  <docidentifier primary="true" type="ISO">ISO 55000:2014</docidentifier>
   <docnumber>123456</docnumber>
   <date type="issued">
     <on>2014</on>
@@ -118,8 +115,8 @@
   <language>en</language>
   <language>fr</language>
   <script>Latn</script>
-  <abstract format="text/plain" language="en" script="Latn">ISO 19115-1:2014 defines the schema required for ...</abstract>
-  <abstract format="text/plain" language="fr" script="Latn">L'ISO 19115-1:2014 définit le schéma requis pour ...</abstract>
+  <abstract format="text/plain" language="en" script="Latn">ISO 55000:2014:2014 defines the schema required for ...</abstract>
+  <abstract format="text/plain" language="fr" script="Latn">L'ISO 55000:2014:2014 définit le schéma requis pour ...</abstract>
   <status>
     <stage abbreviation="CD">30</stage>
     <substage>substage</substage>

spec/fixtures/sample_iso.xml

@@ -3,7 +3,7 @@
   <title type="main">Geographic information</title>
   <title language="fr" script="Latn" type="title-main">Information géographique</title>
   <title language="fr" script="Latn" type="main">Information géographique</title>
-  <docidentifier type="ISO" primary="true">TC211</docidentifier>
+  <docidentifier type="ISO" primary="true">ISO 55000:2014</docidentifier>
   <date type="issued">
     <on>2014</on>
   </date>

spec/fixtures/sample_iso.yaml

@@ -13,7 +13,7 @@ title:
   script: Latn
   type: main
 docidentifier:
-- content: TC211
+- content: ISO 55000:2014
   type: ISO
   primary: true
 date:

spec/relaton/cli/subcommand_db_spec.rb

@@ -130,7 +130,7 @@ def db_mock(dir)
 
       context "return BibTex" do
         it do
-          out = "@manual{ISOTC211, tile = {Geographic information}}"
+          out = "@manual{ISO55000, tile = {Geographic information}}"
           bib = double "BibItem", to_bibtex: out
           expect(io).to receive(:puts).with(out)
           expect(db).to receive(:fetch_all) do |arg|