refactor(index): tidy constant and test

Author: remarkablemark

dist/index.js

@@ -25,10 +25,10 @@ const cliVersion = '1.2.3';
 const pathToTarball = 'path/to/tarball';
 const pathToCLI = 'path/to/cli';
 
-describe.each(['darwin', 'win32', 'linux'])('when OS is %p', (os) => {
+describe.each(['darwin', 'win32', 'linux'])('when os is %p', (platform) => {
   beforeEach(() => {
-    mockedOs.platform.mockReturnValue(os as NodeJS.Platform);
-    mockedOs.arch.mockReturnValue('arm64');
+    mockedOs.platform.mockReturnValue(platform as NodeJS.Platform);
+    mockedOs.arch.mockReturnValue('arm64' as NodeJS.Architecture);
 
     mockedCore.getInput.mockImplementation((input) => {
       switch (input) {
@@ -44,7 +44,7 @@ describe.each(['darwin', 'win32', 'linux'])('when OS is %p', (os) => {
 
   it('downloads, extracts, and adds CLI to PATH', async () => {
     mockedTc.downloadTool.mockResolvedValueOnce(pathToTarball);
-    const isWin32 = os === 'win32';
+    const isWin32 = platform === 'win32';
     const extract = isWin32 ? mockedTc.extractZip : mockedTc.extractTar;
     extract.mockResolvedValueOnce(pathToCLI);
 

src/index.test.ts

@@ -12,13 +12,13 @@ import {
 
 import { getBinaryPath, getDownloadObject } from './utils';
 
-const DEFAULT_NAME = 'gh';
+const TOOL_NAME = 'gh';
 
 export async function run() {
   try {
     // Get the version and name of the tool to be installed
     const cliVersion = getInput('cli-version');
-    const cliName = getInput('cli-name') || DEFAULT_NAME;
+    const cliName = getInput('cli-name');
     const filename = getBinaryPath('', cliName);
 
     // Find previously cached directory (if applicable)
@@ -44,9 +44,9 @@ export async function run() {
 
       // Rename the binary
       /* istanbul ignore else */
-      if (cliName !== DEFAULT_NAME) {
+      if (cliName !== TOOL_NAME) {
         await exec('mv', [
-          getBinaryPath(binaryDirectory, DEFAULT_NAME),
+          getBinaryPath(binaryDirectory, TOOL_NAME),
           binaryPath,
         ]);
       }