Fix tests.

Author: brass75

src/render_engine_cli/utils.py

@@ -134,7 +134,7 @@ def create_collection_entry(
     filepath: Path, editor: str | None, content: str | None, collection: Collection, **context
 ) -> str:
     """Creates a new entry for a collection"""
-    return collection.content_manager.create_entry(filepath, editor, content, context)
+    return collection.create_entry(filepath=filepath, editor=editor, content=content, metadata=context)
 
 
 def split_args(args: list[str] | None) -> dict[str, str]:

tests/test_cli.py

@@ -55,21 +55,33 @@ def test_import_lib_gets_site():
     pass
 
 
-def test_collection_call():
+def test_collection_call(tmp_path_factory):
     """Tests that you can get content from the parser using `new_entry`"""
     test_collection = Collection()
-    content = create_collection_entry(content=None, collection=test_collection, foo="bar")
-    post = frontmatter.loads(content)
+    content_path1 = tmp_path_factory.getbasetemp()
+    filepath = content_path1 / "test.md"
+    content = create_collection_entry(
+        collection=test_collection, content=None, foo="bar", filepath=filepath, editor=None
+    )
+    assert content.strip() == f"New entry created at {filepath} ."
 
+    post = frontmatter.loads(filepath.read_text())
+    print(filepath.read_text())
     assert post["title"] == "Untitled Entry"
     assert post["foo"] == "bar"
 
 
-def test_collection_call_with_content():
+def test_collection_call_with_content(tmp_path_factory):
     """Tests that you can get content from the parser using `new_entry`"""
     test_collection = Collection()
-    content = create_collection_entry(content="This is a test", collection=test_collection, foo="bar")
-    post = frontmatter.loads(content)
+    content_path1 = tmp_path_factory.getbasetemp()
+    filepath = content_path1 / "test.md"
+    create_collection_entry(
+        content="This is a test", collection=test_collection, foo="bar", filepath=filepath, editor=None
+    )
+    print(filepath.read_text())
+
+    post = frontmatter.loads(filepath.read_text())
 
     assert post["title"] == "Untitled Entry"
     assert post["foo"] == "bar"
@@ -148,16 +160,21 @@ def test_config_loading_invalid_file(tmp_path, monkeypatch, capsys):
     CliConfig().load_config(str(config_file))
 
 
-def test_collection_entry_with_custom_attributes():
+def test_collection_entry_with_custom_attributes(tmp_path_factory):
     """Tests that custom attributes are passed through to collection entry"""
     test_collection = Collection()
-    content = create_collection_entry(
+    content_path1 = tmp_path_factory.getbasetemp()
+    filepath = content_path1 / "test.md"
+
+    create_collection_entry(
         content="Test content",
         collection=test_collection,
         author="Test Author",
         tags="test,example",
+        filepath=filepath,
+        editor=None,
     )
-    post = frontmatter.loads(content)
+    post = frontmatter.loads(filepath.read_text())
 
     assert post["author"] == "Test Author"
     assert post["tags"] == "test,example"

tests/test_cli_commands.py

@@ -162,10 +162,6 @@ def test_new_entry_command_success(runner, test_site_module, monkeypatch):
         assert result.exit_code == 0, result.output
         mock_create_entry.assert_called_once()
 
-        # Check that the file was created
-        created_file = content_dir / "test.md"
-        assert created_file.exists()
-
 
 def test_new_entry_command_with_args(runner, test_site_module, monkeypatch):
     """Tests new_entry command with --args parameter"""
@@ -227,7 +223,12 @@ def test_new_entry_command_missing_required_args(runner):
                 "slug": "slug1",
                 "content": "content",
             },
-            {"date": datetime.datetime.fromisoformat("2025-05-23T00:00:00"), "slug": "slug1", "content": "content"},
+            {
+                "date": datetime.datetime.fromisoformat("2025-05-23T00:00:00"),
+                "slug": "slug1",
+                "content": "content",
+                "title": "New Entry",
+            },
         ),
         (
             {
@@ -239,7 +240,12 @@ def test_new_entry_command_missing_required_args(runner):
                 "content": "content",
                 "include-date": True,
             },
-            {"date": datetime.datetime.fromisoformat("2025-05-23T00:00:00"), "slug": "slug1", "content": "content"},
+            {
+                "date": datetime.datetime.fromisoformat("2025-05-23T00:00:00"),
+                "slug": "slug1",
+                "content": "content",
+                "title": "New Entry",
+            },
         ),
         (
             {
@@ -249,7 +255,7 @@ def test_new_entry_command_missing_required_args(runner):
                 "slug": "slug1",
                 "content": "content",
             },
-            {"slug": "slug1", "content": "content"},
+            {"slug": "slug1", "content": "content", "title": "New Entry"},
         ),
     ],
 )
@@ -290,12 +296,15 @@ def mock_create_collection_entry(**kwargs):
             else:
                 formatted_options.extend([f"--{key}", value])
 
-        print(formatted_options)
-        result = runner.invoke(app, ["new-entry", "--module-site", module_site, *formatted_options])
-        print(result.output)
+        runner.invoke(app, ["new-entry", "--module-site", module_site, *formatted_options])
         # Pop the collection from the passed arguments since it's not relevant.
         passed_args.pop("collection", None)
 
+        # We can remove the editor because we're not actually testing with that.
+        passed_args.pop("editor")
+
+        assert passed_args.pop("filepath") == content_dir / options["filename"]
+
         # include_date needs some special handling.
         if "include_date" in options:
             if not any(arg.startswith("date=") or arg.startswith("date:") for arg in options.get("args", [])):