Skip to content

Commit 239945b

Browse files
author
tok-kkk
committed
use proper context
1 parent a7ff39a commit 239945b

2 files changed

Lines changed: 10 additions & 2 deletions

File tree

cmd/update.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import (
66
"io/ioutil"
77
"net/http"
88
"strings"
9+
"time"
910

1011
"github.com/fatih/color"
1112
"github.com/google/go-github/v31/github"
@@ -95,8 +96,11 @@ systemctl --user restart darknode`, url, ver)
9596
}
9697

9798
func validateVersion(version string) error {
99+
ctx, cancel := context.WithTimeout(context.Background(), 5 *time.Second)
100+
defer cancel()
101+
98102
client := github.NewClient(nil)
99-
_, response, err := client.Repositories.GetReleaseByTag(context.Background(), "renproject", "darknode-release", version)
103+
_, response, err := client.Repositories.GetReleaseByTag(ctx, "renproject", "darknode-release", version)
100104
if err != nil {
101105
return err
102106
}

util/node.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import (
1010
"path/filepath"
1111
"regexp"
1212
"strings"
13+
"time"
1314

1415
"github.com/google/go-github/v31/github"
1516
"github.com/hashicorp/go-version"
@@ -166,8 +167,11 @@ func ValidateTags(have, required string) bool {
166167
// LatestStableRelease checks the darknode release repo and return the version
167168
// of the latest release.
168169
func LatestStableRelease() (string, error) {
170+
ctx, cancel := context.WithTimeout(context.Background(), 5 *time.Second)
171+
defer cancel()
172+
169173
client := github.NewClient(nil)
170-
releases, response, err := client.Repositories.ListReleases(context.Background(), "renproject", "darknode-release", nil)
174+
releases, response, err := client.Repositories.ListReleases(ctx, "renproject", "darknode-release", nil)
171175
if err != nil {
172176
return "", err
173177
}

0 commit comments

Comments
 (0)