change the update command

Author: tok-kkk

cmd/provider/aws.go

@@ -67,7 +67,7 @@ func (p providerAws) Deploy(ctx *cli.Context) error {
 	name := ctx.String("name")
 	tags := ctx.String("tags")
 
-	latestVersion, err := util.LatestReleaseVersion()
+	latestVersion, err := util.LatestStableRelease()
 	if err != nil {
 		return err
 	}

cmd/provider/do.go

@@ -33,7 +33,7 @@ func (p providerDo) Deploy(ctx *cli.Context) error {
 	name := ctx.String("name")
 	tags := ctx.String("tags")
 
-	latestVersion, err := util.LatestReleaseVersion()
+	latestVersion, err := util.LatestStableRelease()
 	if err != nil {
 		return err
 	}

cmd/provider/gcp.go

@@ -71,7 +71,7 @@ func (p providerGcp) Deploy(ctx *cli.Context) error {
 	name := ctx.String("name")
 	tags := ctx.String("tags")
 
-	latestVersion, err := util.LatestReleaseVersion()
+	latestVersion, err := util.LatestStableRelease()
 	if err != nil {
 		return err
 	}

cmd/update.go

@@ -1,12 +1,14 @@
 package main
 
 import (
+	"context"
 	"fmt"
 	"io/ioutil"
 	"net/http"
 	"strings"
 
 	"github.com/fatih/color"
+	"github.com/google/go-github/v31/github"
 	"github.com/hashicorp/go-version"
 	"github.com/renproject/darknode-cli/util"
 	"github.com/renproject/phi"
@@ -26,7 +28,7 @@ func updateNode(ctx *cli.Context) error {
 
 	// Use latest version if user doesn't provide a version number
 	if version == "" {
-		version, err = util.LatestReleaseVersion()
+		version, err = util.LatestStableRelease()
 		if err != nil {
 			return err
 		}
@@ -62,16 +64,13 @@ func updateSingleNode(name, ver string) error {
 		url := fmt.Sprintf("https://github.com/renproject/darknode-release/releases/download/%v", ver)
 		script := fmt.Sprintf(`mv ~/.darknode/bin/darknode ~/.darknode/bin/darknode-backup && 
 curl -sL %v/darknode > ~/.darknode/bin/darknode && 
-curl -sL %v/migration > ~/.darknode/bin/migration &&
 chmod +x ~/.darknode/bin/darknode && 
-chmod +x ~/.darknode/bin/migration &&
 systemctl --user stop darknode &&
 cp -a ~/.darknode/db/. ~/.darknode/db_bak/ &&
-~/.darknode/bin/migration &&
 rm -rf ~/.darknode/db &&
 mv ~/.darknode/db_bak ~/.darknode/db &&
 echo %v > ~/.darknode/version &&
-systemctl --user restart darknode`, url, url, ver)
+systemctl --user restart darknode`, url, ver)
 		err = util.RemoteRun(name, script)
 		if err != nil {
 			color.Red("cannot update darknode %v, error = %v", name, err)
@@ -83,8 +82,8 @@ systemctl --user restart darknode`, url, url, ver)
 }
 
 func validateVersion(version string) error {
-	url := fmt.Sprintf("https://api.github.com/repos/renproject/darknode-release/releases/tags/%v", version)
-	response, err := http.Get(url)
+	client := github.NewClient(nil)
+	_, response ,err := client.Repositories.GetReleaseByTag(context.Background(), "renproject", "darknode-release", version )
 	if err != nil {
 		return err
 	}

go.mod

@@ -8,7 +8,7 @@ require (
 	github.com/ethereum/go-ethereum v1.9.6
 	github.com/fatih/color v1.7.0
 	github.com/google/go-github v17.0.0+incompatible
-	github.com/google/go-querystring v1.0.0 // indirect
+	github.com/google/go-github/v31 v31.0.0
 	github.com/hashicorp/go-version v1.2.0
 	github.com/jbenet/go-base58 v0.0.0-20150317085156-6237cf65f3a6
 	github.com/multiformats/go-multiaddr v0.1.1

go.sum

@@ -112,6 +112,8 @@ github.com/google/go-cmp v0.3.1 h1:Xye71clBPdm5HgqGwUkwhbynsUJZhDbS20FvLhQ2izg=
 github.com/google/go-cmp v0.3.1/go.mod h1:8QqcDgzrUqlUb/G2PQTWiueGozuR1884gddMywk6iLU=
 github.com/google/go-github v17.0.0+incompatible h1:N0LgJ1j65A7kfXrZnUDaYCs/Sf4rEjNlfyDHW9dolSY=
 github.com/google/go-github v17.0.0+incompatible/go.mod h1:zLgOLi98H3fifZn+44m+umXrS52loVEgC2AApnigrVQ=
+github.com/google/go-github/v31 v31.0.0 h1:JJUxlP9lFK+ziXKimTCprajMApV1ecWD4NB6CCb0plo=
+github.com/google/go-github/v31 v31.0.0/go.mod h1:NQPZol8/1sMoWYGN2yaALIBytu17gAWfhbweiEed3pM=
 github.com/google/go-querystring v1.0.0 h1:Xkwi/a1rcvNg1PPYe5vI8GbeBY/jrVuDX5ASuANWTrk=
 github.com/google/go-querystring v1.0.0/go.mod h1:odCYkC5MyYFN7vkCjXpyrEuKhc/BUO6wN/zVPAxq5ck=
 github.com/google/martian v2.1.0+incompatible/go.mod h1:9I4somxYTbIHy5NJKHRl3wXiIaQGbYVAs8BPL6v8lEs=

util/node.go

@@ -1,15 +1,18 @@
 package util
 
 import (
+	"context"
 	"encoding/hex"
-	"encoding/json"
 	"errors"
 	"fmt"
 	"io/ioutil"
 	"net/http"
 	"path/filepath"
+	"regexp"
 	"strings"
 
+	"github.com/google/go-github/v31/github"
+	"github.com/hashicorp/go-version"
 	"github.com/renproject/darknode-cli/darknode"
 	"github.com/renproject/darknode-cli/darknode/addr"
 	"golang.org/x/crypto/ssh"
@@ -160,27 +163,48 @@ func ValidateTags(have, required string) bool {
 	return true
 }
 
-// LatestReleaseVersion checks the darknode release repo and return the version
+// LatestStableRelease checks the darknode release repo and return the version
 // of the latest release.
-func LatestReleaseVersion() (string, error) {
-	url := "https://api.github.com/repos/renproject/darknode-release/releases/latest"
-	response, err := http.Get(url)
+func LatestStableRelease() (string, error) {
+	client := github.NewClient(nil)
+	releases, response ,err := client.Repositories.ListReleases(context.Background(), "renproject", "darknode-release", nil )
 	if err != nil {
 		return "", err
 	}
 	if response.StatusCode != http.StatusOK {
 		return "", fmt.Errorf("cannot get latest darknode release from github, error code = %v", response.StatusCode)
 	}
 
-	resp := struct {
-		TagName string `json:"tag_name"`
-	}{}
-	err = json.NewDecoder(response.Body).Decode(&resp)
-	return resp.TagName, err
+	latest, err := version.NewVersion("0.0.0")
+	if err != nil {
+		return "", err
+	}
+	verReg := "^v?[0-9]+\\.[0-9]+\\.[0-9]+$"
+	for _, release := range releases {
+		match, err := regexp.MatchString(verReg, *release.TagName)
+		if err != nil {
+			return "", err
+		}
+		if match {
+			ver, err:= version.NewVersion(*release.TagName)
+			if err != nil {
+				return "", err
+			}
+			if ver.GreaterThan(latest){
+				latest = ver
+			}
+		}
+	}
+	if latest.String() == "0.0.0"{
+		return "", errors.New("cannot find any stable release")
+	}
+
+	return latest.String(), nil
 }
 
+
 func isDeployed(name string) bool {
 	path := NodePath(name)
 	script := fmt.Sprintf("cd %v && terraform output ip", path)
 	return SilentRun("bash", "-c", script) == nil
-}
+}