Skip to content

Commit 6bbf625

Browse files
committed
resolve some comments
1 parent 067a2c5 commit 6bbf625

6 files changed

Lines changed: 13 additions & 9 deletions

File tree

README.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -226,3 +226,7 @@ or a script file
226226
```sh
227227
darknode exec YOUR-DARKNODE-NAME --file test.sh
228228
```
229+
230+
### Github rate limiting
231+
232+
You can set the `GITHUB_TOKEN` environment variable to increase your github rate limit.

cmd/down.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ func (s status) err() string {
5656
func destroyNode(ctx *cli.Context) error {
5757
force := ctx.Bool("force")
5858
name := ctx.Args().First()
59-
if err := util.NodeExistence(name); err != nil {
59+
if err := util.ValidateNodeExistence(name); err != nil {
6060
return err
6161
}
6262
path := util.NodePath(name)
@@ -103,7 +103,7 @@ func withdraw(ctx *cli.Context) error {
103103

104104
// Parse the input parameters
105105
name := ctx.Args().First()
106-
if err := util.NodeExistence(name); err != nil {
106+
if err := util.ValidateNodeExistence(name); err != nil {
107107
return err
108108
}
109109
withdrawAddress := ctx.String("address")

cmd/main.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ func main() {
7878
Usage: "SSH into one of your Darknode",
7979
Action: func(c *cli.Context) error {
8080
name := c.Args().First()
81-
if err := util.NodeExistence(name); err != nil {
81+
if err := util.ValidateNodeExistence(name); err != nil {
8282
return err
8383
}
8484
ip, err := util.IP(name)
@@ -151,7 +151,7 @@ func main() {
151151
Flags: []cli.Flag{},
152152
Action: func(c *cli.Context) error {
153153
name := c.Args().First()
154-
if err := util.NodeExistence(name); err != nil {
154+
if err := util.ValidateNodeExistence(name); err != nil {
155155
return err
156156
}
157157

cmd/provider/provider.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ func validateCommonParams(ctx *cli.Context) error {
7777
if err := util.ValidateName(name); err != nil {
7878
return err
7979
}
80-
if err := util.NodeExistence(name); err == nil {
80+
if err := util.ValidateNodeExistence(name); err == nil {
8181
return fmt.Errorf("node [%v] already exist", name)
8282
}
8383

cmd/resize.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ var (
2929

3030
func resize(ctx *cli.Context) error {
3131
name := ctx.Args().Get(0)
32-
if err := util.NodeExistence(name); err != nil {
32+
if err := util.ValidateNodeExistence(name); err != nil {
3333
return err
3434
}
3535
newSize := ctx.Args().Get(1)

util/node.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ func ParseNodesFromNameAndTags(name, tags string) ([]string, error) {
3434
} else if name == "" && tags != "" {
3535
return GetNodesByTags(tags)
3636
} else if name != "" && tags == "" {
37-
return []string{name}, NodeExistence(name)
37+
return []string{name}, ValidateNodeExistence(name)
3838
} else {
3939
return nil, ErrTooManyArguments
4040
}
@@ -59,8 +59,8 @@ func ValidateName(name string) error {
5959
return nil
6060
}
6161

62-
// NodeExistence checks if there exists a node with given name.
63-
func NodeExistence(name string) error {
62+
// ValidateNodeExistence checks if there exists a node with given name.
63+
func ValidateNodeExistence(name string) error {
6464
path := filepath.Join(Directory, "darknodes", name)
6565
_, err := os.Stat(path)
6666
return err

0 commit comments

Comments
 (0)