not resetting the signatories in the background to prevent race condition

Author: tok-kkk

replica/replica.go

@@ -132,16 +132,6 @@ func (replica *Replica) Run(ctx context.Context) {
 				case process.Height:
 					replica.proc.State = process.DefaultState().WithCurrentHeight(m)
 					replica.mq.DropMessagesBelowHeight(m)
-				case []id.Signatory:
-					procAllowed := map[id.Signatory]bool{}
-					for _, sig := range m {
-						procAllowed[sig] = true
-					}
-					replica.procsAllowed = procAllowed
-
-					scheduler := scheduler.NewRoundRobin(m)
-					f := len(procAllowed) / 3
-					replica.proc.ResetF(uint64(f), scheduler)
 				}
 			}
 
@@ -232,10 +222,15 @@ func (replica *Replica) ResetHeight(ctx context.Context, newHeight process.Heigh
 		return
 	}
 
-	select {
-	case <-ctx.Done():
-	case replica.mch <- signatories:
+	procAllowed := map[id.Signatory]bool{}
+	for _, sig := range signatories {
+		procAllowed[sig] = true
 	}
+	replica.procsAllowed = procAllowed
+
+	scheduler := scheduler.NewRoundRobin(signatories)
+	f := len(procAllowed) / 3
+	replica.proc.ResetF(uint64(f), scheduler)
 }
 
 // State returns the current height, round and step of the underlying process.