Take into account Sonar comments

Author: thboileau

org.restlet.ext.crypto/src/main/java/org/restlet/ext/crypto/CookieAuthenticator.java

@@ -477,14 +477,14 @@ protected int logout(Request request, Response response) {
      * @return The credentials as a proper challenge response.
      */
     protected ChallengeResponse parseCredentials(String cookieValue) {
+        if (cookieValue == null) {
+            return null;
+        }
+
         try {
             // 1) Decode Base64 string
             byte[] encrypted = Base64.getDecoder().decode(cookieValue);
 
-            if (encrypted == null) {
-                getLogger().warning("Cannot decode cookie credentials : " + cookieValue);
-            }
-
             // 2) Decrypt the credentials
             String decrypted =
                     CryptoUtils.decrypt(getEncryptAlgorithm(), getEncryptSecretKey(), encrypted);

org.restlet.ext.thymeleaf/src/main/java/org/restlet/ext/thymeleaf/TemplateFilter.java

@@ -42,7 +42,7 @@ public abstract class TemplateFilter extends Filter {
     private volatile Resolver<Object> resolverDataModel;
 
     /** Constructor. */
-    public TemplateFilter() {
+    protected TemplateFilter() {
         super();
     }
 
@@ -51,7 +51,7 @@ public TemplateFilter() {
      *
      * @param context The context.
      */
-    public TemplateFilter(Context context) {
+    protected TemplateFilter(Context context) {
         super(context);
     }
 
@@ -61,7 +61,7 @@ public TemplateFilter(Context context) {
      * @param context The context.
      * @param next The next Restlet.
      */
-    public TemplateFilter(Context context, Restlet next) {
+    protected TemplateFilter(Context context, Restlet next) {
         super(context, next);
         this.mapDataModel = null;
         this.resolverDataModel = null;
@@ -74,7 +74,7 @@ public TemplateFilter(Context context, Restlet next) {
      * @param next The next Restlet.
      * @param dataModel The filter's data model.
      */
-    public TemplateFilter(Context context, Restlet next, Map<String, Object> dataModel) {
+    protected TemplateFilter(Context context, Restlet next, Map<String, Object> dataModel) {
         super(context, next);
         this.mapDataModel = dataModel;
         this.resolverDataModel = null;
@@ -87,7 +87,7 @@ public TemplateFilter(Context context, Restlet next, Map<String, Object> dataMod
      * @param next The next Restlet.
      * @param dataModel The filter's data model.
      */
-    public TemplateFilter(Context context, Restlet next, Resolver<Object> dataModel) {
+    protected TemplateFilter(Context context, Restlet next, Resolver<Object> dataModel) {
         super(context, next);
         this.mapDataModel = null;
         this.resolverDataModel = dataModel;

org.restlet.ext.xml/src/main/java/org/restlet/ext/xml/XmlRepresentation.java

@@ -250,7 +250,7 @@ public static String getTextContent(Node node) {
      *
      * @param mediaType The representation's mediaType.
      */
-    public XmlRepresentation(MediaType mediaType) {
+    protected XmlRepresentation(MediaType mediaType) {
         this(mediaType, UNKNOWN_SIZE);
     }
 
@@ -260,7 +260,7 @@ public XmlRepresentation(MediaType mediaType) {
      * @param mediaType The representation's mediaType.
      * @param expectedSize The expected input stream size.
      */
-    public XmlRepresentation(MediaType mediaType, long expectedSize) {
+    protected XmlRepresentation(MediaType mediaType, long expectedSize) {
         super(mediaType, expectedSize);
         this.coalescing = false;
         this.entityResolver = null;

org.restlet.ext.xml/src/main/java/org/restlet/ext/xml/internal/AbstractXmlReader.java

@@ -41,7 +41,7 @@ public abstract class AbstractXmlReader implements XMLReader {
     private final HashMap<String, Object> properties;
 
     /** Default constructor. */
-    public AbstractXmlReader() {
+    protected AbstractXmlReader() {
         this.features = new HashMap<>();
         this.properties = new HashMap<>();
         this.contentHandler = null;

org.restlet/src/main/java/org/restlet/Connector.java

@@ -42,7 +42,7 @@ public abstract class Connector extends Restlet {
      *
      * @param context The context.
      */
-    public Connector(Context context) {
+    protected Connector(Context context) {
         this(context, null);
     }
 
@@ -52,7 +52,7 @@ public Connector(Context context) {
      * @param context The context.
      * @param protocols The supported protocols.
      */
-    public Connector(Context context, List<Protocol> protocols) {
+    protected Connector(Context context, List<Protocol> protocols) {
         super(context);
 
         if (protocols == null) {

org.restlet/src/main/java/org/restlet/Message.java

@@ -62,7 +62,7 @@ public abstract class Message {
     private volatile List<Warning> warnings;
 
     /** Constructor. */
-    public Message() {
+    protected Message() {
         this(null);
     }
 
@@ -71,7 +71,7 @@ public Message() {
      *
      * @param entity The payload of the message.
      */
-    public Message(Representation entity) {
+    protected Message(Representation entity) {
         this.attributes = null;
         this.cacheDirectives = null;
         this.date = null;

org.restlet/src/main/java/org/restlet/Restlet.java

@@ -74,7 +74,7 @@ private static void fireContextChanged(Restlet restlet, Context context) {
     private volatile boolean started;
 
     /** Constructor with null context. */
-    public Restlet() {
+    protected Restlet() {
         this(null);
     }
 
@@ -85,7 +85,7 @@ public Restlet() {
      * @see Context#createChildContext()
      * @param context The context of the Restlet.
      */
-    public Restlet(Context context) {
+    protected Restlet(Context context) {
         this.context = context;
         this.started = false;
         this.name = toString();

org.restlet/src/main/java/org/restlet/engine/CompositeHelper.java

@@ -45,7 +45,7 @@ public abstract class CompositeHelper<T extends Restlet> extends RestletHelper<T
      *
      * @param helped The helped Restlet.
      */
-    public CompositeHelper(T helped) {
+    protected CompositeHelper(T helped) {
         super(helped);
         this.inboundNext = null;
         this.firstInboundFilter = null;

org.restlet/src/main/java/org/restlet/engine/RestletHelper.java

@@ -38,7 +38,7 @@ public abstract class RestletHelper<T extends Restlet> extends Helper {
      *
      * @param helped The helped Restlet.
      */
-    public RestletHelper(T helped) {
+    protected RestletHelper(T helped) {
         this.attributes = new ConcurrentHashMap<>();
         this.helped = helped;
     }

org.restlet/src/main/java/org/restlet/engine/connector/ConnectorHelper.java

@@ -43,7 +43,7 @@ public static org.restlet.service.ConnectorService getConnectorService() {
     private final List<Protocol> protocols;
 
     /** Constructor. */
-    public ConnectorHelper(T connector) {
+    protected ConnectorHelper(T connector) {
         super(connector);
         this.protocols = new CopyOnWriteArrayList<>();
     }