Taken into account PR review comments

Author: thboileau

org.restlet.java/org.restlet/src/main/java/org/restlet/data/Reference.java

@@ -141,8 +141,8 @@ public static String decode(String toDecode, CharacterSet characterSet) {
 		try {
 			result = (characterSet == null) ? toDecode : java.net.URLDecoder.decode(toDecode, characterSet.getName());
 		} catch (UnsupportedEncodingException uee) {
-			Context.getCurrentLogger().log(Level.WARNING,
-					"Unable to decode the string with the " + characterSet.getName() + " character set.", uee);
+			Context.getCurrentLogger().log(Level.WARNING, uee,
+					() -> "Unable to decode the string with the " + characterSet.getName() + " character set.");
 		}
 
 		return result;

org.restlet.java/org.restlet/src/test/java/org/restlet/data/ReferenceTestCase.java

@@ -61,7 +61,7 @@ protected Reference getReference() {
      * Test addition methods.
      */
     @Test
-    void testAdditions() throws Exception {
+    void testAdditions() {
         final Reference ref = new Reference("http://restlet.org");
         ref.addQueryParameter("abc", "123");
         assertEquals("http://restlet.org?abc=123", ref.toString());
@@ -618,7 +618,7 @@ void testTargetRef() {
      * Test references that are unequal.
      */
     @Test
-    void testUnEquals() throws Exception {
+    void testUnEquals() {
         final String uri1 = "http://restlet.org/";
         final String uri2 = "http://restlet.net/";
         final Reference ref1 = new Reference(uri1);
@@ -682,8 +682,9 @@ class TestFailures {
                 "https://normal.com[user@vulndetector].com/",
                 "https://normal.com[@]vulndetector.com/"
         })
-        void shouldFailWhenParsingIncorrectHosts(String reference) {
-            assertThrows(IllegalArgumentException.class, () -> new Reference(reference).getAuthority());
+        void shouldFailWhenParsingIncorrectHosts(String url) {
+            final Reference reference = new Reference(url);
+            assertThrows(IllegalArgumentException.class, reference::getAuthority);
         }
 
         @ParameterizedTest
@@ -694,24 +695,27 @@ void shouldFailWhenParsingIncorrectHosts(String reference) {
                 "https://[ffff::127.0.0.4000]",
                 "https://[0:0::vulndetector.com]:80",
                 "https://[2001:db8::vulndetector.com]"})
-        void shouldFailWhenParsingIncorrectIPv6Hosts(String reference) {
-            assertThrows(IllegalArgumentException.class, () -> new Reference(reference).getAuthority());
+        void shouldFailWhenParsingIncorrectIPv6Hosts(String url) {
+            final Reference reference = new Reference(url);
+            assertThrows(IllegalArgumentException.class, reference::getAuthority);
         }
 
         @ParameterizedTest
         @ValueSource(strings = {
                 "http://localhost:18:19",
                 "http://localhost:18ab"})
-        void shouldFailWhenParsingIncorrectPort(String reference) {
-            assertThrows(IllegalArgumentException.class, () -> new Reference(reference).getAuthority());
+        void shouldFailWhenParsingIncorrectPort(String url) {
+            final Reference reference = new Reference(url);
+            assertThrows(IllegalArgumentException.class, reference::getAuthority);
         }
 
         @ParameterizedTest
         @ValueSource(strings = {
                 "https>://vulndetector.com/path",
                 "https%25://vulndetector.com/path"})
-        void shouldFailWhenParsingIncorrectScheme(String reference) {
-            assertThrows(IllegalArgumentException.class, () -> new Reference(reference).getScheme());
+        void shouldFailWhenParsingIncorrectScheme(String url) {
+            final Reference reference = new Reference(url);
+            assertThrows(IllegalArgumentException.class, reference::getScheme);
         }
     }
 }