Minor improvements

Author: bixuehujin

src/Validator.php

@@ -23,7 +23,7 @@ protected function builtInTypes()
     {
         return [
             'integer' => 'is_integer',
-            'float' => 'is_float',
+            'double' => 'is_double',
             'boolean' => 'is_bool',
             'string' => 'is_string',
             'number' => [$this, 'isNumber'],
@@ -86,10 +86,10 @@ protected function getType($value)
     /**
      * Add a new type.
      *
-     * @param $type
-     * @param $definition
+     * @param string $type
+     * @param mixed $definition
      */
-    public function addType($type, $definition)
+    public function addType(string $type, $definition)
     {
         if (isset($this->types[$type])) {
             throw new \InvalidArgumentException("The type: $type is already exists");
@@ -111,7 +111,7 @@ public function addError($key, $message)
         $this->errors[$key] = $message;
     }
 
-    public function reset()
+    protected function reset()
     {
         $this->errors = [];
     }

tests/JsonTypeTest.php

@@ -12,7 +12,7 @@
  */
 class JsonTypeTest extends PHPUnit_Framework_TestCase
 {
-    protected function createJsonType()
+    protected function createValidator()
     {
         return new Validator();
     }
@@ -23,7 +23,7 @@ public function basicTypes()
             ['string', 'foobar', true],
             ['string', 123, false],
             ['integer', 123, true],
-            ['float', 123.1, true],
+            ['double', 123.1, true],
 
             ['number', 123.1, true],
             ['number', 234, true],
@@ -44,7 +44,7 @@ public function basicTypes()
      */
     public function testMatchBasicTypes($type, $data, $result)
     {
-        $json = $this->createJsonType();
+        $json = $this->createValidator();
 
         $method = $result ? 'assertTrue' : 'assertFalse';
 
@@ -73,7 +73,7 @@ protected function userData()
 
     public function testMatchCustomType()
     {
-        $json = $this->createJsonType();
+        $json = $this->createValidator();
 
         $json->addType('user', $this->userType());
 
@@ -83,7 +83,7 @@ public function testMatchCustomType()
 
     public function testMatchArrayOfCustomType()
     {
-        $json = $this->createJsonType();
+        $json = $this->createValidator();
 
         $json->addType('user', $this->userType());
 
@@ -92,7 +92,7 @@ public function testMatchArrayOfCustomType()
 
     public function testAddCustomTypeThroughCallable()
     {
-        $json = $this->createJsonType();
+        $json = $this->createValidator();
 
         $json->addType('timestamp', function ($value) {
             if ((!is_string($value) && !is_numeric($value)) || strtotime($value) === false) {
@@ -174,7 +174,7 @@ public function typeErrorMessages()
      */
     public function testErrorMessages($value, $type, $key, $message)
     {
-        $json = $this->createJsonType();
+        $json = $this->createValidator();
 
         $this->assertFalse($json->matches($value, $type));
         $this->assertEquals($message, $json->getErrors()[$key] ?? '');