Skip to content

Commit ac0b732

Browse files
committed
Build: for now, don't error on RWX loadable segments
Right now on some CI builds we get: aarch64-linux-gnu-gcc -nostdlib -fPIC -Wl,--warn-common -Wl,--no-undefined \ -Wl,--fatal-warnings -Wl,-shared -Wl,-Bsymbolic -L/usr/lib64 \ -L/__w/certwrapper/certwrapper/gnu-efi/ -Wl,--build-id=sha1 \ -Wl,--hash-style=sysv -o certmule.so certmule.o sbat_data.o \ /usr/lib/gcc/aarch64-linux-gnu/12/libgcc.a \ -T /__w/certwrapper/certwrapper/elf_aarch64_efi.lds /usr/bin/aarch64-linux-gnu-ld: warning: certmule.so has a LOAD segment with RWX permissions collect2: error: ld returned 1 exit status make: *** [../Makefile:115: certmule.so] Error 1 Right now this breaks CI despite no code change from when CI worked (due to the distros being updated). The segments themselves don't really matter (they exist in ELF but not in PE), so we could plausibly fix them, but that belongs in a different patch series. Unfortunately some of the linkers we're testing against don't support "--no-warn-rwx-segments", and some of them don't support "--no-error-rwx-segments". So for right now, I'm disabling "--fatal-warnings" instead. Signed-off-by: Peter Jones <pjones@redhat.com>
1 parent 6311d04 commit ac0b732

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ BUILDFLAGS := $(CFLAGS) -fPIC -Werror -Wall -Wextra -fshort-wchar \
2525
-I$(GNUEFIDIR)/inc/$(ARCH) \
2626
-I$(GNUEFIDIR)/inc/protocol
2727
CCLDFLAGS ?= -nostdlib -fPIC -Wl,--warn-common \
28-
-Wl,--no-undefined -Wl,--fatal-warnings \
28+
-Wl,--no-undefined \
2929
-Wl,-shared -Wl,-Bsymbolic -L$(LIBDIR) -L$(GNUEFIDIR) \
3030
-Wl,--build-id=sha1 -Wl,--hash-style=sysv
3131
LD = $(CROSS_COMPILE)ld

0 commit comments

Comments
 (0)