* added stack trace to onLoginFailed and onError callbacks

Author: rithik-dev

CHANGELOG.md

@@ -1,5 +1,6 @@
 ## [1.0.6] - 16/07/2022
 
+* **BREAKING:** Added stack trace to onLoginFailed and onError callbacks
 * Added a boolean linkWithExistingUser to link the new credentials with an existing signed-in user, instead of creating a new one.
 * Added onError callback for general purpose errors by the library
 
@@ -10,9 +11,9 @@
 
 ## [1.0.5] - 10/07/2022
 
-* BREAKING: Renamed flag timeOutDuration to autoRetrievalTimeOutDuration
-* BREAKING: Renamed verifyOTP to verifyOtp
-* BREAKING: Updated verifyOtp function signature to not take a named argument, and accept otp as a positional argument
+* **BREAKING:** Renamed flag timeOutDuration to autoRetrievalTimeOutDuration
+* **BREAKING:** Renamed verifyOTP to verifyOtp
+* **BREAKING:** Updated verifyOtp function signature to not take a named argument, and accept otp as a positional argument
 * Added a new otpExpirationDuration flag, as autoRetrievalTimeOutDuration is a completely different parameter.
 * Added callback onCodeSent and flag signOutOnSuccessfulVerification
 * Added isSendingCode flag to controller

README.md

@@ -121,10 +121,10 @@ FirebasePhoneAuthHandler(
       debugPrint("autoVerified: $autoVerified");
       debugPrint("Login success UID: ${userCredential.user?.uid}");
     },
-    onLoginFailed: (authException) {
+    onLoginFailed: (authException, stackTrace) {
       debugPrint("An error occurred: ${authException.message}");
     },
-    onError: (error) {},
+    onError: (error, stackTrace) {},
 ),
 ```
 
@@ -320,12 +320,12 @@ class _VerifyPhoneNumberScreenState extends State<VerifyPhoneNumberScreen>
             (route) => false,
           );
         },
-        onLoginFailed: (authException) {
+        onLoginFailed: (authException, stackTrace) {
           showSnackBar('Something went wrong!');
           log(VerifyPhoneNumberScreen.id, error: authException.message);
           // handle error further if needed
         },
-        onError: (error) {
+        onError: (error, stackTrace) {
           showSnackBar('An error occurred!');
         },
         builder: (context, controller) {

lib/src/auth_controller.dart

@@ -155,11 +155,11 @@ class FirebasePhoneAuthController extends ChangeNotifier {
           autoVerified: false,
         );
       }
-    } on FirebaseAuthException catch (e) {
-      _onLoginFailed?.call(e);
+    } on FirebaseAuthException catch (e, s) {
+      _onLoginFailed?.call(e, s);
       return false;
-    } catch (e) {
-      _onError?.call(e);
+    } catch (e, s) {
+      _onError?.call(e, s);
       return false;
     }
   }
@@ -180,7 +180,7 @@ class FirebasePhoneAuthController extends ChangeNotifier {
     }
 
     verificationFailedCallback(FirebaseAuthException authException) {
-      _onLoginFailed?.call(authException);
+      _onLoginFailed?.call(authException, null);
     }
 
     codeSentCallback(
@@ -220,11 +220,11 @@ class FirebasePhoneAuthController extends ChangeNotifier {
       }
 
       return true;
-    } on FirebaseAuthException catch (e) {
-      _onLoginFailed?.call(e);
+    } on FirebaseAuthException catch (e, s) {
+      _onLoginFailed?.call(e, s);
       return false;
-    } catch (e) {
-      _onError?.call(e);
+    } catch (e, s) {
+      _onError?.call(e, s);
       return false;
     }
   }
@@ -267,11 +267,11 @@ class FirebasePhoneAuthController extends ChangeNotifier {
       if (_signOutOnSuccessfulVerification) await signOut();
       _onLoginSuccess?.call(authResult, autoVerified);
       return true;
-    } on FirebaseAuthException catch (e) {
-      _onLoginFailed?.call(e);
+    } on FirebaseAuthException catch (e, s) {
+      _onLoginFailed?.call(e, s);
       return false;
-    } catch (e) {
-      _onError?.call(e);
+    } catch (e, s) {
+      _onError?.call(e, s);
       return false;
     }
   }

lib/src/type_definitions.dart

@@ -3,5 +3,13 @@ import 'dart:async';
 import 'package:firebase_auth/firebase_auth.dart';
 
 typedef OnLoginSuccess = FutureOr<void> Function(UserCredential, bool);
-typedef OnLoginFailed = FutureOr<void> Function(FirebaseAuthException);
-typedef OnError = FutureOr<void> Function(Object);
+
+typedef OnLoginFailed = FutureOr<void> Function(
+  FirebaseAuthException,
+  StackTrace?,
+);
+
+typedef OnError = FutureOr<void> Function(
+  Object,
+  StackTrace,
+);