Simplify subscription disposal

unsubscribe without arguments "[u]nsubscribes all listeners to
messages on this channel. This removes all earlier subscriptions."

Also, Ably staff explained to me that "[...] you don't need to call
leave() if calling detach(): the server enforces the invariant
that a client cannot be present on a channel they are not attached to,
so detach() will also cause that client to leave the presence set)."

Author: jscheid

javascript_client/src/subscriptions/createAblyHandler.ts

@@ -68,7 +68,6 @@ function createAblyHandler(options: AblyHandlerOptions) {
         observer.onCompleted()
       }
     }
-
     ;(async () => {
       try {
         // POST the subscription like a normal query
@@ -134,28 +133,9 @@ function createAblyHandler(options: AblyHandlerOptions) {
         try {
           if (channel) {
             const disposedChannel = channel
-            disposedChannel.unsubscribe("update", updateHandler)
-
-            const leavePromise = new Promise((resolve, reject) => {
-              const callback = (err: Types.ErrorInfo) => {
-                if (err) {
-                  reject(new AblyError(err))
-                } else {
-                  resolve()
-                }
-              }
-
-              if (isAnonymousClient()) {
-                disposedChannel.presence.leaveClient(
-                  anonymousClientId,
-                  callback
-                )
-              } else {
-                disposedChannel.presence.leave(callback)
-              }
-            })
+            disposedChannel.unsubscribe()
 
-            const detachPromise = new Promise((resolve, reject) => {
+            await new Promise((resolve, reject) => {
               disposedChannel.detach((err: Types.ErrorInfo) => {
                 if (err) {
                   reject(new AblyError(err))
@@ -165,7 +145,6 @@ function createAblyHandler(options: AblyHandlerOptions) {
               })
             })
 
-            await Promise.all([leavePromise, detachPromise])
             ably.channels.release(disposedChannel.name)
           }
         } catch (error) {