Skip to content

Commit 5f76e18

Browse files
committed
Remove libev_scheduler because it's broken on Ruby head and looks unmaintained
1 parent 00b72d2 commit 5f76e18

7 files changed

Lines changed: 0 additions & 35 deletions

File tree

Gemfile

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,10 @@ gem 'pry'
99
gem 'pry-stack_explorer', platform: :ruby
1010

1111
if RUBY_VERSION >= "3.0"
12-
gem "libev_scheduler"
1312
gem "evt"
1413
end
1514

1615
if RUBY_VERSION >= "3.2.0"
17-
gem "minitest-mock"
1816
gem "async", "~>2.0"
1917
gem "minitest-mock"
2018
end

gemfiles/mongoid_8.gemfile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ gem "ruby-prof", platform: :ruby
88
gem "pry"
99
gem "pry-stack_explorer", platform: :ruby
1010
gem "mongoid", "~> 8.0"
11-
gem "libev_scheduler"
1211
gem "evt"
1312
gem "async"
1413
gem "concurrent-ruby", "1.3.4"

gemfiles/mongoid_9.gemfile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ gem "ruby-prof", platform: :ruby
77
gem "pry"
88
gem "pry-stack_explorer", platform: :ruby
99
gem "mongoid", "~> 9.0"
10-
gem "libev_scheduler"
1110
gem "evt"
1211
gem "async"
1312
gem "minitest-mock"

gemfiles/rails_7.2_postgresql.gemfile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ gem "pg", platform: :ruby
1111
gem "sequel"
1212
gem "evt"
1313
gem "async"
14-
gem "libev_scheduler"
1514
gem "google-protobuf"
1615

1716
gemspec path: "../"

gemfiles/rails_master.gemfile

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@ gem 'sqlite3'
1111
gem 'pg'
1212
gem "sequel"
1313
gem "evt"
14-
if RUBY_ENGINE == "ruby" # This doesn't work on truffle-ruby because there's no `IO::READABLE`
15-
gem "libev_scheduler"
16-
end
1714
gem "async"
1815
gem "google-protobuf"
1916
gem "redis"

spec/graphql/dataloader/nonblocking_dataloader_spec.rb

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -245,12 +245,6 @@ def self.included(child_class)
245245
end
246246

247247
if RUBY_ENGINE == "ruby" && !ENV["GITHUB_ACTIONS"]
248-
describe "With libev_scheduler" do
249-
require "libev_scheduler"
250-
let(:scheduler_class) { Libev::Scheduler }
251-
include NonblockingDataloaderAssertions
252-
end
253-
254248
describe "with evt" do
255249
require "evt"
256250
let(:scheduler_class) { Evt::Scheduler }

spec/graphql/dataloader_spec.rb

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1325,27 +1325,6 @@ def make_schema_from(schema)
13251325

13261326
include DataloaderAssertions
13271327
end
1328-
1329-
if RUBY_ENGINE == "ruby" && !ENV["GITHUB_ACTIONS"]
1330-
describe "nonblocking: true with libev" do
1331-
require "libev_scheduler"
1332-
def make_schema_from(schema)
1333-
Class.new(schema) do
1334-
use GraphQL::Dataloader, nonblocking: true
1335-
end
1336-
end
1337-
1338-
before do
1339-
Fiber.set_scheduler(Libev::Scheduler.new)
1340-
end
1341-
1342-
after do
1343-
Fiber.set_scheduler(nil)
1344-
end
1345-
1346-
include DataloaderAssertions
1347-
end
1348-
end
13491328
end
13501329

13511330
describe "example from #3314" do

0 commit comments

Comments
 (0)