Avoid setting camera with empty config

naftalibeder · naftalibeder · commit 762c1e764e5e · 2024-09-16T10:31:46.000-05:00
See mapbox/mapbox-maps-android#2454
diff --git a/android/src/main/java/com/rnmapbox/rnmbx/components/camera/CameraUpdateItem.kt b/android/src/main/java/com/rnmapbox/rnmbx/components/camera/CameraUpdateItem.kt
@@ -76,10 +76,11 @@ class CameraUpdateItem(
             }
         }
         val map = mMap.get()
-        if (map == null) {
+        if (map == null || mCameraUpdate.center == null) {
             isCameraActionCancelled = true
             return
         }
+
         val animationOptions = MapAnimationOptions.Builder();
 
         // animateCamera / easeCamera only allows positive duration

Original file line number	Diff line number	Diff line change
`@@ -76,10 +76,11 @@ class CameraUpdateItem(`
`76`	`76`	`}`
`77`	`77`	`}`
`78`	`78`	`val map = mMap.get()`
`79`		`- if (map == null) {`
	`79`	`+ if (map == null \|\| mCameraUpdate.center == null) {`
`80`	`80`	`isCameraActionCancelled = true`
`81`	`81`	`return`
`82`	`82`	`}`
	`83`	`+`
`83`	`84`	`val animationOptions = MapAnimationOptions.Builder();`
`84`	`85`
`85`	`86`	`// animateCamera / easeCamera only allows positive duration`