Updating the strpos() check to use a type-safe

Rican7 · Rican7 · commit 996006997fed · 2016-01-11T17:28:12.000-05:00
strict equals, thanks to @mcos reminding me. 👍
diff --git a/src/Robin/Ntlm/Message/AbstractAuthenticateMessageEncoder.php b/src/Robin/Ntlm/Message/AbstractAuthenticateMessageEncoder.php
@@ -126,7 +126,7 @@ public function identifyTargetName($username, $nt_domain, ServerChallenge $serve
          * @link https://msdn.microsoft.com/en-us/library/windows/desktop/aa380525(v=vs.85).aspx
          * @link http://davenport.sourceforge.net/ntlm.html#nameVariations
          */
-        if (strpos($username, static::USER_PRINCIPAL_NAME_SEPARATOR)) {
+        if (false !== strpos($username, static::USER_PRINCIPAL_NAME_SEPARATOR)) {
             $target_name = '';
         }
 

Original file line number	Diff line number	Diff line change
`@@ -126,7 +126,7 @@ public function identifyTargetName($username, $nt_domain, ServerChallenge $serve`
`126`	`126`	`* @link https://msdn.microsoft.com/en-us/library/windows/desktop/aa380525(v=vs.85).aspx`
`127`	`127`	`* @link http://davenport.sourceforge.net/ntlm.html#nameVariations`
`128`	`128`	`*/`
`129`		`- if (strpos($username, static::USER_PRINCIPAL_NAME_SEPARATOR)) {`
	`129`	`+ if (false !== strpos($username, static::USER_PRINCIPAL_NAME_SEPARATOR)) {`
`130`	`130`	`$target_name = '';`
`131`	`131`	`}`
`132`	`132`