Skip to content

Commit 6e6d8c0

Browse files
Merge pull request #1311 from rocket-admin/saved-filters-notification
Saved filters notification
2 parents c87ca98 + 52020aa commit 6e6d8c0

6 files changed

Lines changed: 19 additions & 27 deletions

File tree

frontend/src/app/app.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ export class AppComponent {
5959
public isSaas = (environment as any).saas;
6060
userActivity;
6161
userInactive: Subject<any> = new Subject();
62-
currentFeatureNotificationId: string = 'full-white-label';
62+
currentFeatureNotificationId: string = 'saved-filters';
6363
isFeatureNotificationShown: boolean = false;
6464

6565
userLoggedIn = null;

frontend/src/app/components/dashboard/db-table-view/saved-filters-panel/saved-filters-dialog/saved-filters-dialog.component.css

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,10 @@
1-
.filters-header {
2-
display: flex;
3-
align-items: center;
4-
justify-content: space-between;
5-
margin-top: 16px;
6-
}
7-
81
.filters-content {
92
display: grid;
103
grid-template-columns: auto 228px 0 1fr 160px 32px;
114
grid-column-gap: 8px;
125
align-content: flex-start;
136
align-items: flex-start;
7+
padding-top: 4px !important;
148
}
159

1610
.filters-select {

frontend/src/app/components/dashboard/db-table-view/saved-filters-panel/saved-filters-dialog/saved-filters-dialog.component.html

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,32 +1,29 @@
11
<form #tableFiltersForm="ngForm" (ngSubmit)="handleSaveFilters()" class="filters-form">
22
<h1 mat-dialog-title class="filters-header">
3-
<span>Save Filters for <strong>{{ data.displayTableName }}</strong> table</span>
4-
<a mat-icon-button mat-dialog-close
5-
routerLink="/dashboard/{{data.connectionID}}/{{data.tableName}}/settings"
6-
matTooltip="Advanced settings">
7-
<mat-icon>settings</mat-icon>
8-
</a>
3+
<span>New Fast Filter for <strong>{{ data.displayTableName }}</strong></span>
94
</h1>
105
<app-content-loader *ngIf="!fields || !tableTypes; else filterControls"></app-content-loader>
116
<ng-template #filterControls>
127
<mat-dialog-content class="filters-content">
138
<!-- Filter Name and Description Fields -->
149
<mat-form-field appearance="outline" class="full-width">
15-
<mat-label>Filter Name</mat-label>
10+
<mat-label>Fast Filter name</mat-label>
1611
<input matInput required
1712
name="filters_set_name"
1813
[(ngModel)]="data.filtersSet.name">
1914
<mat-error *ngIf="!data.filtersSet.name">
20-
Filter name is required
15+
Fast filter name is required
2116
</mat-error>
2217
</mat-form-field>
2318

24-
<h3 class="section-title">Define Filters and Dynamic Column</h3>
25-
<p class="section-description">Select filters to apply and optionally mark one column as dynamic</p>
19+
<h3 class="section-title">Conditions & Main column</h3>
20+
<p class="section-description">
21+
Select which conditions to add and choose a Main column. Main columns remain editable, while conditions are set.
22+
</p>
2623

2724
<!-- Filter Selection -->
2825
<mat-form-field class="filters-select" appearance="outline">
29-
<mat-label>Add filter by...</mat-label>
26+
<mat-label>Click here to add condition</mat-label>
3027
<input type="text" matInput name="filter_columns"
3128
[matAutocomplete]="auto"
3229
[formControl]="fieldSearchControl">
@@ -144,7 +141,7 @@ <h3 class="section-title">Define Filters and Dynamic Column</h3>
144141
<mat-checkbox
145142
[checked]="dynamicColumn === value.key"
146143
(change)="toggleDynamicColumn(value.key)">
147-
Dynamic column
144+
Main column
148145
</mat-checkbox>
149146
</div>
150147
<button mat-icon-button type="button" class="filter-delete-button"

frontend/src/app/components/dashboard/db-table-view/saved-filters-panel/saved-filters-panel.component.html

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,12 @@
77
angularticsAction="Saved filters: first time setup is clicked"
88
(click)="handleOpenSavedFiltersDialog()">
99
<mat-icon>tune</mat-icon>
10-
Setup custom filters
10+
Create Fast Filter
1111
</button>
1212

1313
<button *ngIf="accessLevel === 'edit' && savedFilterData.length !== 0"
1414
mat-icon-button type="button"
15+
matTooltip="Set up, edit, or remove Fast Filters"
1516
[matMenuTriggerFor]="menu"
1617
angulartics2On="click"
1718
angularticsAction="Saved filters: open menu is clicked">
@@ -20,7 +21,7 @@
2021
<mat-menu #menu="matMenu">
2122
<button mat-menu-item (click)="handleOpenSavedFiltersDialog()">
2223
<mat-icon>add</mat-icon>
23-
Create new filter
24+
New Fast Filter
2425
</button>
2526
<button mat-menu-item
2627
*ngFor="let filter of savedFilterData"

frontend/src/app/components/feature-notification/feature-notification.component.html

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
<div class="feature-notification">
22
<div class="feature-notification__content">
3-
<img class="feature-notification__image" src="assets/feture-images/white-label.gif" alt="Feature Notification Icon">
4-
<h1 class="feature-notification__title">New: Make it yours</h1>
3+
<img class="feature-notification__image" src="assets/feture-images/saved-filters.gif" alt="Feature Notification Icon">
4+
<h1 class="feature-notification__title">New: Fast Filters</h1>
55
<p class="feature-notification__description">
6-
Customize your favicon and page title, and add branding to your Rocketadmin experience.
6+
Save your filter setups and quickly change options on the fly
77
</p>
88
</div>
99
<div class="actions">
10-
<a mat-button class="actions__secondary" routerLink="/company" (click)="dismiss.emit()">
10+
<!--<a mat-button class="actions__secondary" routerLink="/company" (click)="dismiss.emit()">
1111
Set up now
12-
</a>
12+
</a>-->
1313
<button type="button" mat-flat-button color="accent" class="actions__primary" (click)="dismiss.emit()">
1414
Got it
1515
</button>
5.3 MB
Loading

0 commit comments

Comments
 (0)