Skip to content

Commit bc96ab0

Browse files
saved filters: fix structure passing
1 parent 5b0b08b commit bc96ab0

4 files changed

Lines changed: 15 additions & 3 deletions

File tree

frontend/src/app/components/dashboard/db-table-view/db-table-view.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ <h2 class="mat-h2 table-name">{{ displayName }}</h2>
179179
</mat-chip-row>
180180
</div>
181181

182-
<app-saved-filters-panel
182+
<app-saved-filters-panel *ngIf="tableData && tableData.structure && tableData.widgets"
183183
[connectionID]="connectionID"
184184
[selectedTableName]="name"
185185
[selectedTableDisplayName]="displayName"

frontend/src/app/components/dashboard/db-table-view/saved-filters-panel/saved-filters-panel.component.css

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,10 @@
4444
margin-top: -8px;
4545
}
4646

47+
.column-name strong {
48+
margin-left: 8px;
49+
}
50+
4751
.static-filters {
4852
display: flex;
4953
flex-wrap: wrap;

frontend/src/app/components/dashboard/db-table-view/saved-filters-panel/saved-filters-panel.component.html

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,11 @@
3737
<form *ngIf="savedFilterMap[selectedFilterSetId]?.dynamicColumn"
3838
class="dynamic-column-editor"
3939
(ngSubmit)="applyDynamicColumnChanges()">
40-
<span class="column-name mat-body-1">where <strong>{{ savedFilterMap[selectedFilterSetId]?.dynamicColumn.column }}</strong></span>
40+
<span class="column-name mat-body-1">where
41+
<strong *ngIf="getComparatorType(getInputType(savedFilterMap[selectedFilterSetId]?.dynamicColumn.column)) !== 'nonComparable'">
42+
{{ savedFilterMap[selectedFilterSetId]?.dynamicColumn.column }}
43+
</strong>
44+
</span>
4145
<mat-form-field *ngIf="getComparatorType(getInputType(savedFilterMap[selectedFilterSetId]?.dynamicColumn.column)) === 'text'" appearance="outline">
4246
<mat-select [(ngModel)]="savedFilterMap[selectedFilterSetId].dynamicColumn.operator"
4347
name="textComparator"

frontend/src/app/components/dashboard/db-table-view/saved-filters-panel/saved-filters-panel.component.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import { ActivatedRoute, Router } from '@angular/router';
22
import { Component, EventEmitter, Input, OnDestroy, OnInit, Output } from '@angular/core';
3+
import { TableField, TableForeignKey } from 'src/app/models/table';
34

45
import { AccessLevel } from 'src/app/models/user';
56
import { CommonModule } from '@angular/common';
@@ -18,7 +19,6 @@ import { MatSelectModule } from '@angular/material/select';
1819
import { MatTabsModule } from '@angular/material/tabs';
1920
import { MatTooltipModule } from '@angular/material/tooltip';
2021
import { SavedFiltersDialogComponent } from './saved-filters-dialog/saved-filters-dialog.component';
21-
import { TableForeignKey } from 'src/app/models/table';
2222
import { TablesService } from 'src/app/services/tables.service';
2323
import { UIwidgets } from 'src/app/consts/record-edit-types';
2424
import { filterTypes } from 'src/app/consts/filter-types';
@@ -123,6 +123,10 @@ export class SavedFiltersPanelComponent implements OnInit, OnDestroy {
123123
this.router.navigate([`/dashboard/${this.connectionID}/${this.selectedTableName}`], { queryParams });
124124
}
125125
});
126+
127+
this.tableRowStructure = Object.assign({}, ...this.structure.map((field: TableField) => {
128+
return {[field.column_name]: field};
129+
}));
126130
}
127131

128132
loadSavedFilters() {

0 commit comments

Comments
 (0)