Fix test errors for go 1.24.5

Author: jshufro

shared/services/alerting/alerting.go

@@ -218,7 +218,7 @@ const (
 func alertClientSyncComplete(cfg *config.RocketPoolConfig, client ClientKind) error {
 	alertName := fmt.Sprintf("%sClientSyncComplete", client)
 	if !isAlertingEnabled(cfg) {
-		logMessage(fmt.Sprintf("alerting is disabled, not sending %s.", alertName))
+		logMessage("alerting is disabled, not sending %s.", alertName)
 		return nil
 	}
 

shared/services/rewards/generator-v8_test.go

@@ -54,7 +54,7 @@ func newV8Test(t *testing.T, index uint64) *v8Test {
 
 func (t *v8Test) failIf(err error) {
 	if err != nil {
-		t.Fatalf(err.Error())
+		t.Fatal(err)
 	}
 }
 

shared/services/rewards/utils.go

@@ -1,6 +1,7 @@
 package rewards
 
 import (
+	"errors"
 	"fmt"
 	"io"
 	"math/big"
@@ -258,7 +259,7 @@ func (i *IntervalInfo) DownloadRewardsFile(cfg *config.RocketPoolConfig, isDaemo
 		errBuilder.WriteString(fmt.Sprintf("Downloading files with timeout %v failed.\n", timeout))
 	}
 
-	return fmt.Errorf(errBuilder.String())
+	return errors.New(errBuilder.String())
 
 }