Default rule changes (#7)

* WIP: default rule changes

* style changes to error page

* removed details and summary wip

Co-authored-by: Troy Coutu <Autre31415@gmail.com>

Author: kethinov

index.js

@@ -22,10 +22,16 @@ module.exports = (app, params) => {
 
   // default html-validate rules to use when none are passed
   const defaultRules = {
-    extends: ['html-validate:recommended'],
-    rules: {
-      'attr-case': 'off',
-      'attr-quotes': 'off'
+    extends: ['html-validate:recommended'], // use the project's recommended rules, except...
+    rules: { // the defaults have some problems, so we're changing them
+      'attr-case': { // has to do with permitted case (uppercase or lowercase) for attributes
+        style: 'lowercase', // forces lowercase attributes
+        ignoreForeign: true // except in cases of non-HTML elements, e.g. <svg viewBox="0 0 100 100">
+      },
+      'attr-quotes': 'off', // allows single or double quotes
+      'no-conditional-comment': 'off', // conditional comments are still useful sometimes and they're technically valid html, so there's no reason to have this rule
+      'no-trailing-whitespace': 'off', // linters should enforce this, not validators
+      'prefer-button': 'off' // this rule incorrectly disallows <input type="submit"> https://gitlab.com/html-validate/html-validate/-/issues/90
     }
   }
 

templates/errorPage.html

@@ -10,7 +10,10 @@
   <main>
     <article>
       <style>
+        /* prism styles */
         ${prismStyle}
+
+        /* roosevelt customizations */
         h1 {
           color: #000;
         }
@@ -49,10 +52,8 @@
         .markup {
           font-family: monospace;
           background-color: #fff;
-          overflow: hidden;
           padding: 0.5em;
           border-radius: .25em;
-          box-shadow: .1em .1em .5em rgba(0,0,0,.45);
           line-height: 0;
           counter-reset: line;
         }