Skip to content

Use activeTab permission #57

@justincy

Description

@justincy

Whenever a new widget/scraper is added we have to update the extension's permissions. When an existing user downloads the update with the permission change it will disable the extension and show a warning in the settings window (which is hard to find unless you notice the button turned orange are curious enough to figure out why).

This is one of two big reasons why I haven't added support for more sites (the other is testing; hard to keep up with changes to websites).

We can probably avoid this issue by using the activeTab permission. It will require a small refactor:

  • Be a browserAction instead of a pageAction (show the button at all times in the toolbar; handle case where the icon is clicked on a page with no recognizable data; probably just show the blank fields).
  • Instead of the person data being loaded by default when the user navigates to a page, we will have to wait to process the data when the user clicks on the icon. This will require us to show a loading icon in the popup until the data is loaded.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions