avifArrayPush: Fix oldPtr leak if avifAlloc fails

wantehchang · wantehchang · commit 2b1478469b61 · 2026-02-05T17:10:52.000-08:00
diff --git a/src/utils.c b/src/utils.c
@@ -113,6 +113,7 @@ void * avifArrayPush(void * arrayStruct)
         size_t oldByteCount = (size_t)arr->elementSize * arr->capacity;
         arr->ptr = (uint8_t *)avifAlloc(oldByteCount * 2);
         if (arr->ptr == NULL) {
+            arr->ptr = oldPtr;
             return NULL;
         }
         memset(arr->ptr + oldByteCount, 0, oldByteCount);

Original file line number	Diff line number	Diff line change
`@@ -113,6 +113,7 @@ void * avifArrayPush(void * arrayStruct)`
`113`	`113`	`size_t oldByteCount = (size_t)arr->elementSize * arr->capacity;`
`114`	`114`	`arr->ptr = (uint8_t )avifAlloc(oldByteCount 2);`
`115`	`115`	`if (arr->ptr == NULL) {`
	`116`	`+ arr->ptr = oldPtr;`
`116`	`117`	`return NULL;`
`117`	`118`	`}`
`118`	`119`	`memset(arr->ptr + oldByteCount, 0, oldByteCount);`