fix: address PR review comments for IvorySQL#1002

- Update comment in oracle_quote_identifier() to mention # and $
- Add test case for #- JSON delete operator without spaces

Author: rophy

src/backend/oracle_parser/liboracle_parser.c

@@ -1272,8 +1272,9 @@ oracle_quote_identifier(const char *ident)
 {
 	/*
 	 * Can avoid quoting if ident starts with a lowercase letter or underscore
-	 * and contains only lowercase letters, digits, and underscores, *and* is
-	 * not any SQL keyword.  Otherwise, supply quotes.
+	 * and contains only lowercase letters, digits, underscores, and the
+	 * special characters # and $ (for Oracle compatibility), *and* is not any
+	 * SQL keyword.  Otherwise, supply quotes.
 	 */
 	int			nquotes = 0;
 	bool		safe;

src/oracle_test/regress/expected/ora_identifiers.out

@@ -82,5 +82,11 @@ SELECT '{"b":2}'::jsonb#>>'{b}' AS jsonb_path_no_space;
  2
 (1 row)
 
+SELECT '{"a":1,"b":2}'::jsonb#-'{a}' AS jsonb_delete_no_space;
+ jsonb_delete_no_space 
+-----------------------
+ {"b": 2}
+(1 row)
+
 -- Clean up
 DROP TABLE test_hash_ident;

src/oracle_test/regress/sql/ora_identifiers.sql

@@ -44,6 +44,7 @@ SELECT B'1010' # B'1100' AS bit_xor;
 -- Verify JSON path operators work without spaces (issue was potential conflict)
 SELECT '{"a":1}'::json#>'{a}' AS json_path_no_space;
 SELECT '{"b":2}'::jsonb#>>'{b}' AS jsonb_path_no_space;
+SELECT '{"a":1,"b":2}'::jsonb#-'{a}' AS jsonb_delete_no_space;
 
 -- Clean up
 DROP TABLE test_hash_ident;