Skip to content

Commit a6ad6df

Browse files
committed
fix: address remaining CodeRabbit review findings
- Add SQLERROR/OSERROR guards to enterprise-19 ALTER SYSTEM REGISTER - Update README directory tree to reflect new layout
1 parent fe70e69 commit a6ad6df

2 files changed

Lines changed: 13 additions & 7 deletions

File tree

tests/README.md

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -114,27 +114,30 @@ archives are gitignored (except `example-*` bootstrapping fixtures).
114114
```
115115
tests/
116116
conftest.py # Fixture discovery + SQL tag → pytest marker mapping
117-
test_fixtures.py # Redo log regression tests
118-
test_e2e.py # End-to-end tests (requires live Oracle)
119117
pytest.ini # Marker registration
120118
119+
environments/ # Oracle container environments
120+
free-23/ # Oracle Free 23c
121+
xe-21/ # Oracle XE 21c
122+
xe-21-official/ # Oracle XE 21c (official image)
123+
enterprise-19/ # Oracle Enterprise 19c
124+
rac/ # Oracle RAC (VM-based)
125+
121126
fixtures/ # Local fixture cache (mostly gitignored)
127+
test_fixtures.py # Redo log regression tests
122128
<scenario>.tar.gz # Compressed fixture (gitignored, generated by `make fixtures`)
123129
<scenario>/ # Extracted (gitignored)
124130
redo/*.dbf
125131
schema/TEST-chkpt-<scn>.json
126132
expected/output.json
127133
128134
sql/ # SQL test infrastructure (requires live Oracle)
135+
test_e2e.py # End-to-end tests (requires live Oracle)
129136
inputs/ # SQL scenarios
130137
basic-crud.sql # Single-file format
131138
example/ # Split format (setup.sql + test.sql)
132139
setup.sql
133140
test.sql
134-
environments/ # Oracle container environments
135-
free-23/ # Oracle Free 23c
136-
xe-21/ # Oracle XE 21c
137-
xe-21-official/ # Oracle XE 21c (official image)
138141
scripts/
139142
generate.sh # Generate + validate one fixture
140143
compare.py # OLR vs LogMiner comparison
@@ -146,7 +149,7 @@ tests/
146149
rac.sh # RAC: SSH + podman exec to RAC VM
147150
generated/ # Locally generated fixtures (gitignored)
148151
149-
debezium/ # Debezium twin-test (OLR vs LogMiner adapters)
152+
dbz-twin/ # Debezium twin-test (OLR vs LogMiner adapters)
150153
```
151154

152155
## Input Formats

tests/environments/enterprise-19/oracle-init/01-setup.sh

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,10 @@ set -e
88

99
# Register PDB service with listener (needed for external connections)
1010
sqlplus -S / as sysdba <<'SQL'
11+
WHENEVER SQLERROR EXIT SQL.SQLCODE
12+
WHENEVER OSERROR EXIT FAILURE
1113
ALTER SYSTEM REGISTER;
14+
EXIT
1215
SQL
1316

1417
# Enable supplemental logging (idempotent)

0 commit comments

Comments
 (0)