fix: address CodeRabbit review on PR #19

- fuzz-test.sh: add lob-logminer to help text, show down-before-up workflow
- kafka-consumer.py: wait for all 3 topics before subscribing, fail on missing
- perf/docker-compose.yaml: use ${VM_HOST:?} for fail-fast on missing env var
- validator.py: normalize table name (strip schema, uppercase) for LOB detection
- .env: clarify VM_HOST must be sourced from vm-env.sh
- rac.sh: auto-source vm-env.sh when VM_HOST is not set

Author: rophy

tests/dbz-twin/rac/fuzz-test.sh

@@ -12,13 +12,14 @@
 #   run [duration-min]    Deploy fuzz workload and run for N minutes (default: 30)
 #   status                Show consumer/validator status and OLR memory
 #   validate              Run validator (wait for idle timeout, report results)
-#   logs [component]      Show logs (kafka, logminer, olr, consumer, validator, olr-vm)
+#   logs [component]      Show logs (kafka, logminer, olr, lob-logminer, consumer, validator, olr-vm)
 #   down                  Stop and remove all containers + volumes
 #   help                  Show this help
 #
 # Typical workflow:
-#   ./fuzz-test.sh up              # start infrastructure
-#   ./fuzz-test.sh run 60          # run 60-minute fuzz workload
+#   ./fuzz-test.sh down             # clean up any previous run
+#   ./fuzz-test.sh up               # start infrastructure
+#   ./fuzz-test.sh run 60           # run 60-minute fuzz workload
 #   ./fuzz-test.sh status          # check progress
 #   ./fuzz-test.sh validate        # wait for drain + validate
 #   ./fuzz-test.sh logs validator  # investigate mismatches

tests/dbz-twin/rac/kafka-consumer.py

@@ -146,12 +146,16 @@ def main():
     # Wait for topics to appear, then subscribe
     all_topics = [LM_TOPIC, OLR_TOPIC, OLR_LOB_TOPIC]
     print(f"Waiting for topics: {', '.join(all_topics)}...", flush=True)
-    for attempt in range(60):
+    for _ in range(60):
         topics = consumer.topics()
-        if LM_TOPIC in topics or OLR_TOPIC in topics:
-            print(f"  Found topics: {[t for t in all_topics if t in topics]}", flush=True)
+        if all(t in topics for t in all_topics):
+            print(f"  Found all topics: {all_topics}", flush=True)
             break
         time.sleep(5)
+    else:
+        missing = [t for t in all_topics if t not in topics]
+        print(f"ERROR: Missing Kafka topics after 5 min: {missing}", flush=True)
+        sys.exit(1)
 
     consumer.subscribe(all_topics)
     # Force metadata refresh

tests/dbz-twin/rac/perf/docker-compose.yaml

@@ -44,7 +44,7 @@ services:
     # Override with: docker compose run swingbench -uc 8 -rt 01:00.00
     command:
       - "-cs"
-      - "//${VM_HOST}:1521/ORCLPDB"
+      - "//${VM_HOST:?VM_HOST is required}:1521/ORCLPDB"
       - "-u"
       - "soe"
       - "-p"

tests/dbz-twin/rac/validator.py

@@ -245,7 +245,7 @@ def main():
                         "SELECT table_name FROM olr_events WHERE event_id = ? LIMIT 1",
                         (eid,)).fetchone()
                 event_table = tbl_row['table_name'] if tbl_row else '?'
-                is_lob = event_table in LOB_TABLES
+                is_lob = event_table.split('.')[-1].upper() in LOB_TABLES
 
                 if in_lm and not in_olr:
                     total_missing_olr += 1

tests/environments/rac/.env

@@ -1,4 +1,4 @@
 # DB_CONN is set by the rac driver (tests/sql/scripts/drivers/rac.sh)
-# VM_HOST is auto-detected by vm-env.sh
+# VM_HOST must be set before running RAC tests — source vm-env.sh first
 PDB_NAME=ORCLPDB
 INCLUDE_TAGS=rac

tests/sql/scripts/drivers/rac.sh

@@ -36,6 +36,10 @@ DB_CONN="olr_test/olr_test@//racnodep1:1521/ORCLPDB"
 source "$SCRIPT_DIR/drivers/base.sh"
 
 # ---- RAC configuration ----
+if [[ -z "${VM_HOST:-}" ]]; then
+    # shellcheck source=/dev/null
+    source "$PROJECT_ROOT/tests/environments/rac/vm-env.sh"
+fi
 VM_HOST="${VM_HOST:?VM_HOST is required — source tests/environments/rac/vm-env.sh}"
 VM_KEY="${VM_KEY:-$PROJECT_ROOT/oracle-rac/assets/vm-key}"
 VM_USER="${VM_USER:-root}"