Skip to content

Commit 4bb0010

Browse files
committed
remove ament_export_link_flags() for atomic operations.
Signed-off-by: Tomoya.Fujita <tomoya.fujita825@gmail.com>
1 parent a663ed7 commit 4bb0010

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

CMakeLists.txt

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,8 +100,10 @@ target_link_libraries(${PROJECT_NAME} ${CMAKE_DL_LIBS})
100100
check_library_exists(atomic __atomic_load_8 "" HAVE_LIBATOMICS)
101101

102102
if(HAVE_LIBATOMICS AND NOT WIN32)
103-
# Exporting link flag since it won't pass ament_export_libraries() existence check
104-
ament_export_link_flags("-latomic")
103+
# Link libatomic into rcutils for fault injection atomic operations.
104+
# Don't export it - downstream packages get atomic symbols transitively
105+
# through librcutils.so, avoiding library resolution issues in containerized
106+
# environments. See https://github.com/ros2/rcutils/issues/525
105107
target_link_libraries(${PROJECT_NAME} atomic)
106108
endif()
107109

0 commit comments

Comments
 (0)