Address code review: clarify doc wording and add explicit type guard in typedArray

Copilot · rotu · web-flow · commit 989f07f5cdfe · 2026-04-02T22:38:50.000Z
Agent-Logs-Url: https://github.com/rotu/structview/sessions/3465639d-8c89-4269-94e2-6dbf1256113f Co-authored-by: rotu <119948+rotu@users.noreply.github.com>
diff --git a/fields.ts b/fields.ts
@@ -327,8 +327,8 @@ export function bool(fieldOffset: number): StructPropertyDescriptor<boolean> {
  * })
  * ```
  *
- * **Predicate function** — the field is absent when `(dv: DataView) => boolean`
- * returns `false`.  Setting the field to a non-null value writes it normally;
+ * **Predicate function** — the field is absent when the predicate returns
+ * `false`.  Setting the field to a non-null value writes it normally;
  * setting to `null` is a no-op.
  *
  * ```ts
@@ -478,7 +478,7 @@ export function typedArray<T>(
         lengthValue = length
       } else if (typeof length === "string") {
         lengthValue = Reflect.get(this, length)
-      } else {
+      } else if (typeof length === "function") {
         lengthValue = length(dv)
       }
       return new species(

Original file line number	Diff line number	Diff line change
`@@ -327,8 +327,8 @@ export function bool(fieldOffset: number): StructPropertyDescriptor<boolean> {`
`327`	`327`	`* })`
`328`	`328`	* ```
`329`	`329`	`*`
`330`		- * Predicate function — the field is absent when `(dv: DataView) => boolean`
`331`		- * returns `false`. Setting the field to a non-null value writes it normally;
	`330`	`+ * Predicate function — the field is absent when the predicate returns`
	`331`	+ * `false`. Setting the field to a non-null value writes it normally;
`332`	`332`	* setting to `null` is a no-op.
`333`	`333`	`*`
`334`	`334`	* ```ts
`@@ -478,7 +478,7 @@ export function typedArray<T>(`
`478`	`478`	`lengthValue = length`
`479`	`479`	`} else if (typeof length === "string") {`
`480`	`480`	`lengthValue = Reflect.get(this, length)`
`481`		`- } else {`
	`481`	`+ } else if (typeof length === "function") {`
`482`	`482`	`lengthValue = length(dv)`
`483`	`483`	`}`
`484`	`484`	`return new species(`