fix: elevate CSS specificity for BS5 radio/checkbox group label margin#1308
Open
elnelson575 wants to merge 7 commits into
Open
fix: elevate CSS specificity for BS5 radio/checkbox group label margin#1308elnelson575 wants to merge 7 commits into
elnelson575 wants to merge 7 commits into
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
elnelson575
force-pushed
the
fix/bs5-radio-button-spacing
branch
from
4f0136c to
40e324d
Compare
gadenbuie
reviewed
May 13, 2026
Per review on #1308, use `.shiny-input-radiogroup.shiny-input-radiogroup` to bump specificity in a way that signals the duplication is purely for specificity, rather than the semantically-misleading `.shiny-input-container.X`. Also unifies inline radio/checkbox label spacing with the stacked variants by winning the specificity tie against Shiny's inline override.
This was referenced May 21, 2026
Draft
Closed
…spacing # Conflicts: # inst/css-precompiled/5/bootstrap.min.css
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.shiny-input-radiogroup.shiny-input-radiogroup).shiny-input-radiogroup.shiny-input-container-inline), so inline radio/checkbox groups now use the same calculated label-to-options spacing as their stacked counterparts.py-shiny, this needs to be merged into bslib, pyshiny needs the change in sass load order (so that this rule wins the specificity cascade), and then needs to revendor assets.What changes visually
Stacked (vertical / many-choice) groups are unchanged. Inline groups gain ~2px of breathing room between the group label and the first option so all three variants are consistent.
Computed
margin-topon.shiny-options-group:Before (main)
After (this PR)
Test plan
radioButtons()label spacing is unchangedradioButtons()label spacing now matches verticalcheckboxGroupInput()label spacing is unchangedcheckboxGroupInput()label spacing now matches vertical