Added unit test for empty string

Author: circlingthesun

dist/angular-gettext.js

@@ -177,6 +177,7 @@ angular.module('gettext').directive('translate', ["gettextCatalog", "$parse", "$
                 post: function (scope, element, attrs) {
                     var countFn = $parse(attrs.translateN);
                     var pluralScope = null;
+                    var linking = true;
 
                     function update() {
                         // Fetch correct translated string.
@@ -189,11 +190,27 @@ angular.module('gettext').directive('translate', ["gettextCatalog", "$parse", "$
                             translated = gettextCatalog.getString(msgid,  null, translateContext);
                         }
 
+                        var oldContents = element.contents();
+
+                        // if (!oldContents.length){
+                        //     $compile(oldContents)(scope);
+                        //     return;
+                        // }
+
+                        // Avoid redundant swaps
+                        if (translated === oldContents.html()){
+                            // Take care of unlinked content
+                            if (linking){
+                                $compile(oldContents)(scope);
+                            }
+                            return;
+                        }
+
                         // Swap in the translation
                         var newWrapper = angular.element('<span>' + translated + '</span>');
                         $compile(newWrapper.contents())(scope);
-                        var oldContents = element.contents();
                         var newContents = newWrapper.contents();
+
                         $animate.enter(newContents, element);
                         $animate.leave(oldContents);
                     }
@@ -205,6 +222,7 @@ angular.module('gettext').directive('translate', ["gettextCatalog", "$parse", "$
                     scope.$on('gettextLanguageChanged', update);
 
                     update();
+                    linking = false;
                 }
             };
         }

dist/angular-gettext.min.js

@@ -59,10 +59,6 @@ angular.module('gettext').directive('translate', function (gettextCatalog, $pars
 
                         var oldContents = element.contents();
 
-                        if(!oldContents){
-                            return;
-                        }
-
                         // Avoid redundant swaps
                         if (translated === oldContents.html()){
                             // Take care of unlinked content
@@ -77,13 +73,8 @@ angular.module('gettext').directive('translate', function (gettextCatalog, $pars
                         $compile(newWrapper.contents())(scope);
                         var newContents = newWrapper.contents();
 
-                        // No animation is required before anything shows
-                        if (linking){
-                            oldContents.replaceWith(newContents);
-                        } else {
-                            $animate.enter(newContents, element);
-                            $animate.leave(oldContents);
-                        }
+                        $animate.enter(newContents, element);
+                        $animate.leave(oldContents);
                     }
 
                     if (attrs.translateN) {

src/directive.js

@@ -20,6 +20,12 @@ describe("Directive", function () {
         });
     }));
 
+    it("Should work on empty strings", function () {
+        var el = $compile("<div><h1 translate></h1></div>")($rootScope);
+        $rootScope.$digest();
+        assert.equal(el.text(), "");
+    });
+
     it("Should return string unchanged when no translation is available", function () {
         var el = $compile("<div><h1 translate>Hello!</h1></div>")($rootScope);
         $rootScope.$digest();