revert max, min

Author: monkstone

lib/jruby_art/helper_methods.rb

@@ -76,18 +76,19 @@ def thread(&block)
 
     # explicitly provide 'processing.org' min instance method
     # to return a float:- a, b and c need to be floats
+    # you might choose to use ruby method directly and then
+    # provide a block to alter comparator eg
+    # args.min(&block) # { |a, b| a.value <=> b.value }
 
-    def min(args, &block)
-      args.min unless block_given?
-      args.min(&block) # { |a, b| a.value <=> b.value }
+    def min(*args)
+      args.min
     end
 
     # explicitly provide 'processing.org' max instance method
-    # to return a float:- a, b and c need to be floats
+    # to return a float:- a, b and c need to be floats see above
 
-    def max(args, &block)
-      args.max unless block_given?
-      args.max(&block) # { |a, b| a.value <=> b.value }
+    def max(*args)
+      args.max
     end
 
     # explicitly provide 'processing.org' dist instance method

pom.xml

@@ -11,7 +11,7 @@ DO NOT MODIFIY - GENERATED CODE
   <modelVersion>4.0.0</modelVersion>
   <groupId>ruby-processing</groupId>
   <artifactId>rp5extras</artifactId>
-  <version>1.2.9</version>
+  <version>1.3.0</version>
   <name>rp5extras</name>
   <description>rp5extras for JRubyArt</description>
   <url>https://github.com/ruby-processing/JRubyArt</url>

test/helper_methods_test.rb

@@ -51,12 +51,10 @@ def test_dist
   end
 
   def test_min
-    assert_equal(min(ARRAY), 'albatross')
-    assert_equal(min(ARRAY) { |a, b| a.length <=> b.length }, 'dog')
+    assert_equal(min(*ARRAY), 'albatross')
   end
 
   def test_max
-    assert_equal(max(ARRAY), 'horse')
-    assert_equal(max(ARRAY) { |a, b| a.length <=> b.length }, 'albatross')
+    assert_equal(max(*ARRAY), 'horse')
   end
 end