Merge branch 'bdewitt/remove_helpers' of github.com:ruby-protobuf/protobuf into bdewitt/remove_helpers

Author: abrandoned

lib/protobuf/field/base_field.rb

@@ -69,7 +69,6 @@ def initialize(message_class, rule, type_class, fully_qualified_name, tag, simpl
         define_to_message_hash!
         define_encode_to_stream!
         set_default_value!
-        tag_encoded
       end
 
       ##

lib/protobuf/field/base_field_method_definitions.rb

@@ -152,9 +152,9 @@ def set_field(values, value, ignore_nil_for_repeated, message_instance)
 
               if value.empty?
                 values.delete(#{fully_qualified_name_string(selph)})
-                message_instance._protobuf_message_required_field_tags << #{selph.tag}
+                message_instance._protobuf_message_unset_required_field_tags << #{selph.tag}
               else
-                message_instance._protobuf_message_required_field_tags.delete(#{selph.tag})
+                message_instance._protobuf_message_unset_required_field_tags.delete(#{selph.tag})
                 values[#{fully_qualified_name_string(selph)}] ||= ::Protobuf::Field::FieldHash.new(self)
                 values[#{fully_qualified_name_string(selph)}].replace(value)
               end
@@ -200,9 +200,9 @@ def set_field(values, value, ignore_nil_for_repeated, message_instance)
 
             if value.empty?
               values.delete(#{fully_qualified_name_string(selph)})
-              message_instance._protobuf_message_required_field_tags << #{selph.tag}
+              message_instance._protobuf_message_unset_required_field_tags << #{selph.tag}
             else
-              message_instance._protobuf_message_required_field_tags.delete(#{selph.tag})
+              message_instance._protobuf_message_unset_required_field_tags.delete(#{selph.tag})
               values[#{fully_qualified_name_string(selph)}] ||= ::Protobuf::Field::FieldArray.new(self)
               values[#{fully_qualified_name_string(selph)}].replace(value)
             end
@@ -247,9 +247,9 @@ def self.define_string_set_field!(selph)
             def set_field(values, value, ignore_nil_for_repeated, message_instance)
               if value.nil?
                 values.delete(#{fully_qualified_name_string(selph)})
-                message_instance._protobuf_message_required_field_tags << #{selph.tag}
+                message_instance._protobuf_message_unset_required_field_tags << #{selph.tag}
               else
-                message_instance._protobuf_message_required_field_tags.delete(#{selph.tag})
+                message_instance._protobuf_message_unset_required_field_tags.delete(#{selph.tag})
                 values[#{fully_qualified_name_string(selph)}] = if value.is_a?(String)
                                                                   value
                                                                 else
@@ -281,9 +281,9 @@ def self.define_base_set_field!(selph)
             def set_field(values, value, ignore_nil_for_repeated, message_instance)
               if value.nil?
                 values.delete(#{fully_qualified_name_string(selph)})
-                message_instance._protobuf_message_required_field_tags << #{selph.tag}
+                message_instance._protobuf_message_unset_required_field_tags << #{selph.tag}
               else
-                message_instance._protobuf_message_required_field_tags.delete(#{selph.tag})
+                message_instance._protobuf_message_unset_required_field_tags.delete(#{selph.tag})
                 values[#{fully_qualified_name_string(selph)}] = coerce!(value)
               end
             end

lib/protobuf/message.rb

@@ -70,7 +70,7 @@ def each_field
     end
 
     def each_field_for_serialization
-      _protobuf_message_required_field_tags.each do |tag|
+      _protobuf_message_unset_required_field_tags.each do |tag|
         fail ::Protobuf::SerializationError, "Required field #{self.class.name}##{_protobuf_message_field[tag].name} does not have a value."
       end
 

lib/protobuf/message/fields.rb

@@ -27,8 +27,8 @@ def _protobuf_message_field
               PROTOBUF_MESSAGE_GET_FIELD
             end
 
-            def _protobuf_message_required_field_tags
-              @_protobuf_message_required_field_tags ||= PROTOBUF_MESSAGE_REQUIRED_FIELD_TAGS.dup
+            def _protobuf_message_unset_required_field_tags
+              @_protobuf_message_unset_required_field_tags ||= PROTOBUF_MESSAGE_REQUIRED_FIELD_TAGS.dup
             end
           RUBY
         end