Skip to content

Commit dfad4ee

Browse files
committed
removing tracing from client and decoder
1 parent 1194147 commit dfad4ee

2 files changed

Lines changed: 2 additions & 10 deletions

File tree

lib/protobuf/rpc/client.rb

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -105,8 +105,7 @@ def on_success=(callable)
105105
def method_missing(method_name, *params)
106106
service = options[:service]
107107
if service.rpc_method?(method_name)
108-
operation = "#{service.name}##{method_name}"
109-
logger.debug { sign_message(operation) }
108+
logger.debug { sign_message("#{service.name}##{method_name}") }
110109
rpc = service.rpcs[method_name.to_sym]
111110

112111
options[:request_type] = rpc.request_type
@@ -127,9 +126,7 @@ def method_missing(method_name, *params)
127126
logger.debug { sign_message("no block given for callbacks") }
128127
end
129128

130-
::OpenTracing.start_active_span(operation) do |scope|
131-
send_request
132-
end
129+
send_request
133130
else
134131
logger.error { sign_message("#{service.name}##{method_name} not rpc method, passing to super") }
135132
super(method_name, *params)

lib/protobuf/rpc/middleware/request_decoder.rb

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,6 @@ def request
5252
raise BadRequestData, "Unable to decode request: #{exception.message}"
5353
end
5454

55-
def trace_context
56-
return nil if request_wrapper.trace.nil? # XXX test
57-
@trace_context ||= request_wrapper.trace.raw.to_s
58-
end
59-
6055
# Decode the incoming request object into our expected request object
6156
#
6257
def request_wrapper

0 commit comments

Comments
 (0)