clean up the run method

Author: abrandoned

lib/protobuf/rpc/servers/zmq/broker.rb

@@ -33,27 +33,9 @@ def run
             # Something went wrong
             break if rc == -1
 
-            readables_include_backend = @poller.readables.include?(@backend_socket)
-            message_count_read_from_backend = 0
-
-            while readables_include_backend && message_count_read_from_backend < backend_poll_weight do
-              message_count_read_from_backend = message_count_read_from_backend + 1
-              process_backend
-              @poller.poll_nonblock
-              readables_include_backend = @poller.readables.include?(@backend_socket)
-            end
-
+            check_and_process_backend
             process_local_queue # Fair ordering so queued requests get in before new requests
-            readables_include_frontend = @poller.readables.include?(@frontend_socket)
-            message_count_read_from_frontend = 0
-
-            while readables_include_frontend && message_count_read_from_frontend < frontend_poll_weight do
-              message_count_read_from_frontend = message_count_read_from_frontend + 1
-              process_frontend
-              break unless local_queue_available? # no need to read frontend just to throw away messages, will prioritize backend when full
-              @poller.poll_nonblock
-              readables_include_frontend = @poller.readables.include?(@frontend_socket)
-            end
+            check_and_process_frontend
           end
         ensure
           teardown
@@ -69,6 +51,31 @@ def backend_poll_weight
           @backend_poll_weight ||= [ENV["PB_ZMQ_SERVER_BACKEND_POLL_WEIGHT"].to_i, 1].max
         end
 
+        def check_and_process_backend
+          readables_include_backend = @poller.readables.include?(@backend_socket)
+          message_count_read_from_backend = 0
+
+          while readables_include_backend && message_count_read_from_backend < backend_poll_weight do
+            message_count_read_from_backend += 1
+            process_backend
+            @poller.poll_nonblock
+            readables_include_backend = @poller.readables.include?(@backend_socket)
+          end
+        end
+
+        def check_and_process_frontend
+          readables_include_frontend = @poller.readables.include?(@frontend_socket)
+          message_count_read_from_frontend = 0
+
+          while readables_include_frontend && message_count_read_from_frontend < frontend_poll_weight do
+            message_count_read_from_frontend += 1
+            process_frontend
+            break unless local_queue_available? # no need to read frontend just to throw away messages, will prioritize backend when full
+            @poller.poll_nonblock
+            readables_include_frontend = @poller.readables.include?(@frontend_socket)
+          end
+        end
+
         def frontend_poll_weight
           @frontend_poll_weight ||= [ENV["PB_ZMQ_SERVER_FRONTEND_POLL_WEIGHT"].to_i, 1].max
         end