Move illegal content writer test to a separate group. Exclude for REXML as xpath results are different for attribute values.

Author: gkellogg

spec/spec_helper.rb

@@ -11,6 +11,11 @@
 require 'rdf/spec/matchers'
 require 'rdf/isomorphic'
 require 'open-uri/cached'
+begin
+  require 'nokogiri'
+rescue LoadError => e
+  :rexml
+end
 
 # Create and maintain a cache of downloaded URIs
 URI_CACHE = File.expand_path(File.join(File.dirname(__FILE__), "uri-cache"))
@@ -20,10 +25,6 @@
 ::RSpec.configure do |c|
   c.filter_run :focus => true
   c.run_all_when_everything_filtered = true
-  c.exclusion_filter = {
-    :ruby => lambda { |version| !(RUBY_VERSION.to_s =~ /^#{version.to_s}/) },
-    :no_jruby => lambda { |version| !(RUBY_PLATFORM.to_s != 'java') },
-  }
   c.include(RDF::Spec::Matchers)
 end
 

spec/writer_spec.rb

@@ -18,27 +18,18 @@ class FOO < RDF::Vocabulary("http://foo/"); end
     context "typed resources" do
       context "resource without type" do
         subject do
-          @graph << [RDF::URI.new("http://release/"), RDF::DC.title, "foo & bar"]
+          @graph << [RDF::URI.new("http://release/"), RDF::DC.title, "foo"]
           serialize(attributes: :untyped)
         end
 
         {
           "/rdf:RDF/rdf:Description/@rdf:about" => "http://release/",
-          "/rdf:RDF/rdf:Description[@dc:title='foo & bar']/@rdf:about" => "http://release/",
-          "/rdf:RDF/rdf:Description/@dc:title" => "foo & bar"
+          "/rdf:RDF/rdf:Description/@dc:title" => "foo"
         }.each do |path, value|
           it "returns #{value.inspect} for xpath #{path}" do
             expect(subject).to have_xpath(path, value, {}, @debug)
           end
         end
-        [
-          '<dc:title>foo &amp; bar</dc:title>',
-          'dc:title=\'foo &amp; bar\''
-          ].each do |value|
-          it "serializes literal value with illegal XML characters to fragment #{value}" do
-            expect(subject).to include(value)
-          end
-        end
       end
 
       context "resource with type" do
@@ -119,7 +110,42 @@ class FOO < RDF::Vocabulary("http://foo/"); end
         end
       end
     end
-  
+
+    context "with illegal content" do
+      context "in attribute", skip: !defined?(::Nokogiri) do
+        subject do
+          @graph << [RDF::URI.new("http://release/"), RDF::DC.title, "foo & bar"]
+          serialize(attributes: :untyped)
+        end
+
+        {
+          "/rdf:RDF/rdf:Description/@rdf:about" => "http://release/",
+          "/rdf:RDF/rdf:Description/@dc:title" => "foo & bar",
+          "/rdf:RDF/rdf:Description/dc:title" => false
+        }.each do |path, value|
+          it "returns #{value.inspect} for xpath #{path}" do
+            expect(subject).to have_xpath(path, value, {}, @debug)
+          end
+        end
+      end
+      context "in element" do
+        subject do
+          @graph << [RDF::URI.new("http://release/"), RDF::DC.title, "foo & bar"]
+          serialize(attributes: :none)
+        end
+
+        {
+          "/rdf:RDF/rdf:Description/@rdf:about" => "http://release/",
+          "/rdf:RDF/rdf:Description/@dc:title" => false,
+          "/rdf:RDF/rdf:Description/dc:title/text()" => "foo &amp; bar"
+        }.each do |path, value|
+          it "returns #{value.inspect} for xpath #{path}" do
+            expect(subject).to have_xpath(path, value, {}, @debug)
+          end
+        end
+      end
+    end
+
     context "with children" do
       before(:each) {
         @graph << [RDF::URI.new("http://release/"), RDF.type, FOO.Release]