Skip to content

Commit 6b9e818

Browse files
authored
Remove visualize_pack from functionality and dependency (#107)
That pack now has so many more options that integrating it back into is not straightforward. Use visualize_pack directly for now
1 parent f530248 commit 6b9e818

9 files changed

Lines changed: 2 additions & 358 deletions

File tree

Gemfile.lock

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ GIT
1717
PATH
1818
remote: .
1919
specs:
20-
packs (0.0.26)
20+
packs (0.0.27)
2121
code_ownership (>= 1.33.0)
2222
packs-specification
2323
packwerk
@@ -27,7 +27,6 @@ PATH
2727
sorbet-runtime
2828
thor
2929
tty-prompt
30-
visualize_packs (<= 0.3.1)
3130

3231
GEM
3332
remote: https://rubygems.org/
@@ -157,8 +156,6 @@ GEM
157156
rubocop-factory_bot (~> 2.22)
158157
rubocop-sorbet (0.7.3)
159158
rubocop (>= 0.90.0)
160-
ruby-graphviz (1.2.5)
161-
rexml
162159
ruby-progressbar (1.13.0)
163160
smart_properties (1.17.0)
164161
sorbet (0.5.10957)
@@ -207,13 +204,6 @@ GEM
207204
unparser (0.6.8)
208205
diff-lcs (~> 1.3)
209206
parser (>= 3.2.0)
210-
visualize_packs (0.3.1)
211-
code_ownership
212-
packs-specification
213-
parse_packwerk
214-
rake
215-
ruby-graphviz
216-
sorbet-runtime
217207
wisper (2.0.1)
218208
yard (0.9.34)
219209
yard-sorbet (0.8.1)

README.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -100,9 +100,6 @@ Make sure there are no spaces between the comma-separated list of paths of direc
100100
## Get info about size and violations for packs
101101
`bin/packs get_info [ packs/my_pack packs/my_other_pack ]`
102102

103-
## Visualize packs
104-
`bin/packs visualize [ packs/my_pack packs/my_other_pack ]`
105-
106103
## Rename a pack
107104
`bin/packs rename`
108105

lib/packs/cli.rb

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -136,13 +136,6 @@ def get_info(*pack_names)
136136
exit_successfully
137137
end
138138

139-
desc 'visualize [ packs/my_pack packs/my_other_pack ]', 'Visualize packs'
140-
sig { params(pack_names: String).void }
141-
def visualize(*pack_names)
142-
Private.visualize(packs: parse_pack_names(pack_names))
143-
exit_successfully
144-
end
145-
146139
desc 'rename', 'Rename a pack'
147140
sig { void }
148141
def rename

lib/packs/private.rb

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -587,11 +587,6 @@ def self.sort_keys(config)
587587
config.to_a.sort_by { |key, _value| T.unsafe(sort_order).index(key) }.to_h
588588
end
589589

590-
sig { params(packs: T::Array[Packs::Pack]).void }
591-
def self.visualize(packs: Packs.all)
592-
VisualizePacks.package_graph!(packs)
593-
end
594-
595590
sig { returns(String) }
596591
def self.rename_pack
597592
<<~WARNING

lib/packs/private/interactive_cli.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
require 'packs/private/interactive_cli/use_cases/update'
2020
require 'packs/private/interactive_cli/use_cases/validate'
2121
require 'packs/private/interactive_cli/use_cases/lint_package_yml_files'
22-
require 'packs/private/interactive_cli/use_cases/visualize'
2322

2423
module Packs
2524
module Private

lib/packs/private/interactive_cli/use_cases/visualize.rb

Lines changed: 0 additions & 44 deletions
This file was deleted.

packs.gemspec

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Gem::Specification.new do |spec|
22
spec.name = 'packs'
3-
spec.version = '0.0.26'
3+
spec.version = '0.0.27'
44
spec.authors = ['Gusto Engineers']
55
spec.email = ['dev@gusto.com']
66

@@ -37,7 +37,6 @@ Gem::Specification.new do |spec|
3737
spec.add_dependency 'sorbet-runtime'
3838
spec.add_dependency 'thor'
3939
spec.add_dependency 'tty-prompt'
40-
spec.add_dependency 'visualize_packs', '<= 0.3.1'
4140

4241
# rubocop:disable Gemspec/DevelopmentDependencies
4342
spec.add_development_dependency 'bundler', '~> 2.2'

sorbet/rbi/gems/visualize_packs@0.3.1.rbi

Lines changed: 0 additions & 230 deletions
This file was deleted.

0 commit comments

Comments
 (0)