fix(tests): resolve linting issues in fitness test reorganization

- Remove unused imports from test files (fixtures now provided by conftest.py)
- Fix line length violations by breaking long lines appropriately
- Improve test readability by extracting long string literals into variables

Author: deanq

tests/test_serverless/test_modules/test_fitness/test_gpu_checks.py

@@ -19,7 +19,7 @@
     _check_gpu_health,
     auto_register_gpu_check,
 )
-from runpod.serverless.modules.rp_fitness import clear_fitness_checks, _fitness_checks
+from runpod.serverless.modules.rp_fitness import _fitness_checks
 
 
 # ============================================================================
@@ -146,7 +146,8 @@ def test_finds_package_binary(self):
 
     def test_returns_none_if_binary_not_found(self):
         """Test returns None when binary not in package."""
-        with patch("runpod.serverless.modules.rp_gpu_fitness.get_binary_path") as mock_get:
+        patch_path = "runpod.serverless.modules.rp_gpu_fitness.get_binary_path"
+        with patch(patch_path) as mock_get:
             mock_get.return_value = None
             path = _get_gpu_test_binary_path()
             assert path is None
@@ -331,8 +332,8 @@ def test_auto_register_nvidia_smi_failed(self):
 
     def test_auto_register_timeout(self):
         """Test auto-registration handles timeout."""
-        with patch("subprocess.run", side_effect=subprocess.TimeoutExpired("nvidia-smi", 5)):
-
+        timeout_error = subprocess.TimeoutExpired("nvidia-smi", 5)
+        with patch("subprocess.run", side_effect=timeout_error):
             auto_register_gpu_check()
 
             # Should handle gracefully and not register

tests/test_serverless/test_modules/test_fitness/test_gpu_integration.py

@@ -14,8 +14,6 @@
 from runpod.serverless.modules.rp_fitness import (
     register_fitness_check,
     run_fitness_checks,
-    clear_fitness_checks,
-    _reset_registration_state,
 )
 from runpod.serverless.modules.rp_gpu_fitness import _check_gpu_health
 
@@ -50,7 +48,9 @@ def mock_gpu_test_binary():
 @pytest.fixture
 def mock_gpu_test_binary_failure():
     """Create a temporary mock gpu_test binary that outputs failure."""
-    with tempfile.NamedTemporaryFile(mode="w", suffix="_gpu_test_fail", delete=False) as f:
+    with tempfile.NamedTemporaryFile(
+        mode="w", suffix="_gpu_test_fail", delete=False
+    ) as f:
         f.write("""#!/bin/bash
 cat <<'EOF'
 Failed to initialize NVML: Driver/library version mismatch
@@ -73,7 +73,9 @@ def mock_gpu_test_binary_failure():
 @pytest.fixture
 def mock_gpu_test_binary_multi_gpu():
     """Create a temporary mock gpu_test binary with multiple GPUs."""
-    with tempfile.NamedTemporaryFile(mode="w", suffix="_gpu_test_multi", delete=False) as f:
+    with tempfile.NamedTemporaryFile(
+        mode="w", suffix="_gpu_test_multi", delete=False
+    ) as f:
         f.write("""#!/bin/bash
 cat <<'EOF'
 Linux Kernel Version: 5.15.0
@@ -121,7 +123,9 @@ async def gpu_check():
         await run_fitness_checks()
 
     @pytest.mark.asyncio
-    async def test_fitness_check_with_failure_binary(self, mock_gpu_test_binary_failure):
+    async def test_fitness_check_with_failure_binary(
+        self, mock_gpu_test_binary_failure
+    ):
         """Test fitness check fails with broken binary output."""
         @register_fitness_check
         async def gpu_check():

tests/test_serverless/test_modules/test_fitness/test_registration.py

@@ -353,7 +353,10 @@ def failing_check():
 
         # Should log error with check name and exception type
         error_calls = [str(call) for call in mock_log.error.call_args_list]
-        assert any("failing_check" in call and "RuntimeError" in call for call in error_calls)
+        has_error = any(
+            "failing_check" in call and "RuntimeError" in call for call in error_calls
+        )
+        assert has_error
 
     @pytest.mark.asyncio
     @patch("runpod.serverless.modules.rp_fitness.log")

tests/test_serverless/test_modules/test_fitness/test_system_checks.py

@@ -22,7 +22,7 @@
     _parse_version,
     auto_register_system_checks,
 )
-from runpod.serverless.modules.rp_fitness import clear_fitness_checks, _fitness_checks
+from runpod.serverless.modules.rp_fitness import _fitness_checks
 
 
 # ============================================================================
@@ -230,16 +230,14 @@ async def test_get_cuda_version_nvcc(self, mock_run):
     async def test_get_cuda_version_nvidia_smi_fallback(self, mock_run):
         """Test CUDA version retrieval fallback to nvidia-smi."""
         # First call (nvcc) fails, second call (nvidia-smi) succeeds
+        nvidia_smi_output = (
+            "\n+-----------------------------------------------------------------------+\n"
+            "| NVIDIA-SMI 565.57    Driver Version: 565.57   CUDA Version: 12.7    |\n"
+            "+-----------------------------------------------------------------------+\n"
+        )
         mock_run.side_effect = [
             FileNotFoundError(),  # nvcc not found
-            MagicMock(
-                returncode=0,
-                stdout="""
-+-----------------------------------------------------------------------------------------+
-| NVIDIA-SMI 565.57                 Driver Version: 565.57         CUDA Version: 12.7     |
-|--------------------------------------+------------------------+------------------------+
-"""
-            ),
+            MagicMock(returncode=0, stdout=nvidia_smi_output),
         ]
         version = await _get_cuda_version()
         assert version is not None
@@ -261,12 +259,12 @@ async def test_get_cuda_version_nvidia_smi_no_cuda_in_output(self, mock_run):
     @patch("subprocess.run")
     async def test_get_cuda_version_extraction_from_nvidia_smi(self, mock_run):
         """Test that CUDA version is correctly extracted from nvidia-smi."""
+        smi_output = (
+            "NVIDIA-SMI 565.57    Driver Version: 565.57    CUDA Version: 12.2"
+        )
         mock_run.side_effect = [
             FileNotFoundError(),  # nvcc not found
-            MagicMock(
-                returncode=0,
-                stdout="NVIDIA-SMI 565.57    Driver Version: 565.57    CUDA Version: 12.2"
-            ),
+            MagicMock(returncode=0, stdout=smi_output),
         ]
         version = await _get_cuda_version()
         assert version is not None