Tests improvements

- fixed warnings in tests
- improved periodic_task function
- added new hooks to .pre-commit-config

Author: aleksey925

.pre-commit-config.yaml

@@ -1,10 +1,12 @@
 repos:
   - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v4.2.0
+    rev: v4.3.0
     hooks:
       - id: check-yaml
       - id: end-of-file-fixer
       - id: trailing-whitespace
+      - id: name-tests-test
+        args: ["--pytest-test-first"]
 
   - repo: https://github.com/pycqa/isort
     rev: 5.10.1

src/runtime_config/libs/asyncio_utils.py

@@ -7,7 +7,7 @@ def periodic_task(
 ) -> asyncio.Task:  # type: ignore[type-arg]
     async def wrapper() -> None:
         while True:
-            await func()
             await asyncio.sleep(callback_time)
+            await func()
 
     return asyncio.create_task(wrapper())

tests/libs/test_asyncio_utils.py

@@ -0,0 +1,19 @@
+import pytest
+from pytest_mock import MockerFixture
+
+from runtime_config.libs.asyncio_utils import periodic_task
+
+
+async def test_periodic_task(mocker: MockerFixture):
+    # arrange
+    callback_time = 10
+    func_mock = mocker.AsyncMock(side_effect=Exception)
+    sleep_mock = mocker.patch('runtime_config.libs.asyncio_utils.asyncio.sleep')
+
+    # act
+    with pytest.raises(Exception):
+        await periodic_task(func=func_mock, callback_time=callback_time)
+
+    # assert
+    assert func_mock.call_count == 1
+    sleep_mock.assert_called_with(callback_time)

tests/test_runtime_config.py

@@ -11,6 +11,7 @@
 from runtime_config.runtime_config import _instance
 
 
+@pytest.mark.usefixtures('mock_periodic_task')
 class TestRuntimeConfig:
     async def test_create(self, mocker: MockerFixture, init_settings):
         # arrange
@@ -431,3 +432,8 @@ def source_mock_fixture(mocker: MockerFixture):
     source_mock = mocker.Mock(spec=sources.ConfigServerSrc)
     source_mock.get_settings.return_value = []
     return source_mock
+
+
+@pytest.fixture(name='mock_periodic_task')
+def mock_periodic_task_fixture(mocker: MockerFixture):
+    mocker.patch('runtime_config.runtime_config.periodic_task')