keep queries when doing lucky, :: or crate-name searches

[Emilgardis]

enables https://docs.rs/releases/search?query=tokio::spawn&i-am-feeling-lucky=1&go_to_first=true

to go to first result after redirect

useful for %s keyword search

[Nemo157]

I would really like something like go_to_exact in rustdoc that we could add for the :: redirects. I don't think we can just add go_to_first always because e.g. https://docs.rs/tokio?search=tokio::span&go_to_first=true goes to the tokio::spawn docs.

In the meantime I think merging the queries like this is good, we could also support it on the crate-name handler so that https://docs.rs/tokio::spawn?go_to_first=true works; but that's unlikely to be something you want to write yourself so having this only for people wrapping the search handler seems fine.

[Emilgardis]

Implemented the proposed functionality!

[Emilgardis]

Hmm, I managed to get the web-server spinning now (on a mac :3) and I'm not sure this is working as intended.

nevermind, it works, not sure what I did wrong

[syphar]

In general a deeper integration with rustdoc specifics feels good to me.

( though rust-analyzers experimental/externalDocs could solve this issue already in a more correct way)

[Emilgardis]

I just realized I did this on my master branch, so a squash + force push will probably have github close this issue :) ...

I think I've fixed this by changing the default branch on my fork

[Emilgardis]

@rustbot modify labels: +T-waiting-on-review, -T-waiting-on-author

[rustbot]

Error: Label T-waiting-on-review can only be set by Rust team members

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

[Emilgardis]

it's S...

@rustbot modify labels: +S-waiting-on-review, -S-waiting-on-author

[syphar]

Thank you for pushing this improvement forward!

I had ideas around some improvements, let me know what you think!

[Emilgardis]

I've applied the suggestions

[Emilgardis]

@rustbot modify labels: +S-waiting-on-review, -S-waiting-on-author

edit: it really doesn't let me, the config file suggests I should be able to

[syphar]

@Emilgardis I'm on my phone so I don't see details
Could you check the failing tests?

[Emilgardis]

ah great, I only tested locally with cargo test -- web::r as I assumed that would be the only place that this would take effect. Should be fixed now

[syphar]

I'm sorry about the back & forth, I'll approve & merge.

Manual test is fine, removing the empty ? at the end I'll leave to myself later :)

[GuillaumeGomez]

About testing, it could also be added into #1698.